Skip to content

Add LG-Based ASUS SDRW-8D2S-U (LG GP75N inside) - #434

Merged
superg merged 4 commits into
superg:mainfrom
moisespr123:patch-1
Aug 11, 2026
Merged

Add LG-Based ASUS SDRW-8D2S-U (LG GP75N inside)#434
superg merged 4 commits into
superg:mainfrom
moisespr123:patch-1

Conversation

@moisespr123

@moisespr123 moisespr123 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Newer ASUS SDRW-8D2S-U are actually an LG GP75N inside the enclosure with ASUS firmware. These have a +6 offset not listed in the AccurateRip but can confirm as:

  1. it is the same hardware platform LG is using along their models (GP60NB50, GP65NB60, GP96, GPM2, etc)
  2. using 3 discs in EAC confirms it is +6 and accuraterip confirms the tracks are ripped accurately.

It seems this drive was purged because previous models used a Samsung drive inside, but the LG is MediaTek-based (MT1887) hence the +6 offset.

Summary by CodeRabbit

  • New Features
    • Added support for ASUS SDRW-08D2S-U firmware A812 with the internal LG GP75N drive model.

Newer ASUS SDRW-8D2S-U are actually an LG GP75N inside the enclosure with ASUS firmware. These have a +6 offset not listed in the AccurateRip but can confirm as:
1. it is the same hardware platform LG is using along their models (GP60NB50, GP65NB60, GP96, GPM2, etc)
2. using 3 discs in EAC confirms it is +6 and accuraterip confirms the tracks are ripped accurately.

It seems this drive was purged because previous models used a Samsung drive inside, but the LG is MediaTek-based (MT1887) hence the +6 offset.
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bafde73f-d128-43a8-899e-24cf15ae2681

📥 Commits

Reviewing files that changed from the base of the PR and between 9aacff0 and cf6da64.

📒 Files selected for processing (1)
  • drive.ixx

📝 Walkthrough

Walkthrough

The drive database adds an ASUS SDRW-08D2S-U firmware A812 entry for the internal LG GP75N model. The entry specifies a +6 read offset, DATA_C2_SUB sector order, and generic drive type.

Changes

Drive offset mapping

Layer / File(s) Summary
Add ASUS drive offset mapping
drive.ixx
Adds the ASUS SDRW-08D2S-U firmware A812 configuration with a +6 read offset, DATA_C2_SUB sector order, and generic drive type.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: deterous

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the ASUS drive variant with LG GP75N hardware, which is the main subject of the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@moisespr123

Copy link
Copy Markdown
Contributor Author

Or, should this go into drive.ixx so it checks the firmware (A812)? then apply the offset if this matches? that way it seems it does not apply the offset to incorrect variants of this model?

drive information
  path: E:
  inquiry: ASUS - SDRW-08D2S-U (revision level: A812, vendor specific: M045600 M24N2E04918)
  configuration: GENERIC (read offset: +0, C2 shift: 0, pre-gap start: +0, read method: BE, sector order: DATA_C2_SUB)
  profile: CD-ROM
  read speed: <optimal>

@superg

superg commented Aug 10, 2026

Copy link
Copy Markdown
Owner

This drive is already present: https://github.com/superg/redumper/blob/main/drive.ixx#L217
It wasn't in AccurateRip DB because as you correctly pointed out, ASUS used different drives.

Can you try to update your drive to B901 firmware if possible?

@moisespr123

Copy link
Copy Markdown
Contributor Author

This is not possible because as per note: internal model: DU-8A6NH11B it is a LiteOn drive. Mine is an LG GP75N inside.

@superg

superg commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Ahh, got it, I didn't pay attention.

@superg

superg commented Aug 11, 2026

Copy link
Copy Markdown
Owner

In this case we should add another line to drive.ixx, something like:

    { "ASUS"    , "SDRW-08D2S-U"     , "A812", "", "",    +6,  0, 0, ReadMethod::BE, SectorOrder::DATA_C2_SUB, Type::GENERIC  }, // internal model: DU-8A6NH11B

Please do it like this, remove the change to offset table and let's get that merged.

moisespr123 and others added 3 commits August 11, 2026 08:49
Firmware A812 and offset +6
add LG variant of ASUS SDRW-08D2S-U.
@superg
superg merged commit 5001d68 into superg:main Aug 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants