Add LG-Based ASUS SDRW-8D2S-U (LG GP75N inside) - #434
Conversation
Newer ASUS SDRW-8D2S-U are actually an LG GP75N inside the enclosure with ASUS firmware. These have a +6 offset not listed in the AccurateRip but can confirm as: 1. it is the same hardware platform LG is using along their models (GP60NB50, GP65NB60, GP96, GPM2, etc) 2. using 3 discs in EAC confirms it is +6 and accuraterip confirms the tracks are ripped accurately. It seems this drive was purged because previous models used a Samsung drive inside, but the LG is MediaTek-based (MT1887) hence the +6 offset.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe drive database adds an ASUS SDRW-08D2S-U firmware A812 entry for the internal LG GP75N model. The entry specifies a +6 read offset, DATA_C2_SUB sector order, and generic drive type. ChangesDrive offset mapping
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Or, should this go into drive.ixx so it checks the firmware (A812)? then apply the offset if this matches? that way it seems it does not apply the offset to incorrect variants of this model? |
|
This drive is already present: https://github.com/superg/redumper/blob/main/drive.ixx#L217 Can you try to update your drive to B901 firmware if possible? |
|
This is not possible because as per note: internal model: DU-8A6NH11B it is a LiteOn drive. Mine is an LG GP75N inside. |
|
Ahh, got it, I didn't pay attention. |
|
In this case we should add another line to drive.ixx, something like: Please do it like this, remove the change to offset table and let's get that merged. |
Should be on drive.ixx
Firmware A812 and offset +6
add LG variant of ASUS SDRW-08D2S-U.
Newer ASUS SDRW-8D2S-U are actually an LG GP75N inside the enclosure with ASUS firmware. These have a +6 offset not listed in the AccurateRip but can confirm as:
It seems this drive was purged because previous models used a Samsung drive inside, but the LG is MediaTek-based (MT1887) hence the +6 offset.
Summary by CodeRabbit