Skip to content

Support BU50N in flash_mt1959 - #436

Merged
superg merged 1 commit into
superg:mainfrom
ypsvlq:main
Aug 14, 2026
Merged

Support BU50N in flash_mt1959#436
superg merged 1 commit into
superg:mainfrom
ypsvlq:main

Conversation

@ypsvlq

@ypsvlq ypsvlq commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Tested on BU50N manufactured August 2017 flashing OmniDrive over stock firmware.

Summary by CodeRabbit

  • New Features
    • Added support for the HL-DT-ST BD-RE BU50N drive.
    • Improved recognition of compatible boot-mode firmware and drive configurations.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e30d489d-f308-4f6f-8c15-07ef41da27ee

📥 Commits

Reviewing files that changed from the base of the PR and between 5001d68 and b8953eb.

📒 Files selected for processing (1)
  • drive/flash_mt1959.ixx

📝 Walkthrough

Walkthrough

The MT1959 support list now includes the HL-DT-ST BD-RE BU50N. Firmware validation also accepts MT1959 Boot BU51 drives when the firmware reports MT1959 Boot BU5 .

Changes

MT1959 drive support

Layer / File(s) Summary
Drive support and identifier validation
drive/flash_mt1959.ixx
Adds HL-DT-ST BD-RE BU50N with the MT1959 Boot BU5 configuration ID. Accepts the BU51 drive ID when the firmware ID matches the corresponding BU5 value. Existing exact-match validation remains for other identifiers.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b8953

This is a narrowly scoped support change for BU50N flash handling, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding BU50N support to flash_mt1959.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superg
superg merged commit b775827 into superg:main Aug 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants