Skip to content

fix bad Sector order for ASUS SDRW-08D2S-U LG GP75N-based hardware. - #438

Merged
superg merged 1 commit into
superg:mainfrom
moisespr123:patch-3
Sep 7, 2026
Merged

fix bad Sector order for ASUS SDRW-08D2S-U LG GP75N-based hardware.#438
superg merged 1 commit into
superg:mainfrom
moisespr123:patch-3

Conversation

@moisespr123

@moisespr123 moisespr123 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

ASUS SDRW-08D2S-U A812 should be using DATA_SUB_C2 codes.

Otherwise it is full of C2 errors.

Seems other LGs based on the Mediatek MT1887 platform needs this. Will confirm later with my other discs.

Interestingly, I noticed the ASUS has a lead-in -135 configured in this file. Will need to see if the ASUS SDRW-08U9M-U actually can, as the firmware is also from an LG-based platform similar to the GP60/GP63/GP65/SP80/GP96.

Not sure if there is a tool that can read or cross-flash, read or dump the MT1887 platform from these drives, since they are all identical hardware but different firmware.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected sector ordering for the ASUS SDRW-08D2S-U A812 drive to improve data processing accuracy.

ASUS SDRW-08D2S-U A812 should be using DATA_SUB_C2 codes.

Otherwise it is full of C2 errors.

Seems other LGs based on the Mediatek MT1887 platform needs this. Will confirm later with my other discs.

Interestingly, I noticed the ASUS has a lead-in -135 configured in this file. Will need to see if the ASUS SDRW-08U9M-U actually can, as the firmware is also from an LG-based platform similar to the GP60/GP63/GP65/SP80/GP96.

Not sure if there is a tool that can read or cross-flash, read or dump the MT1887 platform from these drives, since they are all identical hardware but different firmware.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7b41f6b6-0cc3-4851-9c66-ae3f586b0305

📥 Commits

Reviewing files that changed from the base of the PR and between 1874b39 and ed3a0bd.

📒 Files selected for processing (1)
  • drive.ixx

Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The ASUS SDRW-08D2S-U A812 drive database entry now uses DATA_SUB_C2 instead of DATA_C2_SUB for sector ordering.

Changes

Drive database update

Layer / File(s) Summary
Update ASUS sector ordering
drive.ixx
The ASUS SDRW-08D2S-U A812 configuration now specifies DATA_SUB_C2 sector ordering.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ed3a0

This is a narrowly scoped drive-configuration change, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: deterous

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the ASUS drive and the sector-order fix, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superg
superg merged commit 0539fdd into superg:main Sep 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants