Skip to content

Force omnidrive flag - #443

Merged
superg merged 2 commits into
superg:mainfrom
Deterous:force-omnidrive
Sep 7, 2026
Merged

Force omnidrive flag#443
superg merged 2 commits into
superg:mainfrom
Deterous:force-omnidrive

Conversation

@Deterous

@Deterous Deterous commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Useful for OmniDrive-flashed drives that are in enclosures that overwrite drive inquiry data.

Summary by CodeRabbit

  • New Features

    • Added the --force-omnidrive command-line option to enable OmniDrive compatibility for supported non-OmniDrive firmware.
    • The option is disabled by default and can be enabled when needed.
  • Documentation

    • Updated command-line help output to describe the new option and its usage.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: a680547d-7074-44cb-8855-a5af44209f7d

📥 Commits

Reviewing files that changed from the base of the PR and between be72d48 and 67eab57.

📒 Files selected for processing (2)
  • options.ixx
  • redumper.ixx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

Adds the --force-omnidrive option. When enabled for non-OmniDrive firmware, initialization writes an endian-converted OmniDrive version marker to the drive configuration.

Changes

Force OmniDrive Configuration

Layer / File(s) Summary
Force option definition and parsing
options.ixx
Adds the force_omnidrive field, initializes it to false, parses --force-omnidrive, and documents the option in help output.
Forced drive configuration
redumper.ixx
Imports endian conversion support and stores the minimum OmniDrive firmware marker in ctx.drive_config.reserved5 when the option applies.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 67eab

This adds an opt-in flag that marks supported non-OmniDrive firmware as OmniDrive during initialization. The flag and configuration behavior are wired through consistently, with no remaining merge-blocking risk identified.

Suggested reviewers: superg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a flag to force OmniDrive behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superg
superg merged commit 3e15602 into superg:main Sep 7, 2026
11 checks passed
@Deterous
Deterous deleted the force-omnidrive branch September 10, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants