Add PlayStation disc profiles - #444
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds six PlayStation optical-disc profiles, display strings, and mappings to CD, DVD, or BLURAY. ChangesPlayStation optical-disc profiles
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This adds PlayStation disc-profile recognition and routes each supported format to its existing CD, DVD, or Blu-ray handling path. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
How did you verify this? Also, PS3 has CD discs as well. |
|
PS4 BD value is from the recent issue dumping on PS4 Linux, someone in VGPC has logs. Standard CDs like Audio CDs have normal profile values from what I can remember, these new values are only for PlayStation discs. PS3 has CD-ROM support but I don't know of any official ones (most are just burned CD-R), plus the enumeration seems to be logical (2nd to last digit is the PS generation and last digital increments from 0) |
PlayStation 3/4 OEM drives return non-standard values for PlayStation discs.
By adding these profiles to redumper, it will correctly detect and dump PlayStation discs when dumping with PS3/PS4 drives connected to PC, or when dumping on-console (such as with PS4 Linux).
PS5 console/drive is not yet tested, so not sure what PS5 drives or discs do (extrapolating would be 0xFF90 for PS5 discs but won't add until someone tests it).