Skip to content

Add PlayStation disc profiles - #444

Merged
superg merged 1 commit into
superg:mainfrom
Deterous:psdrive
Sep 10, 2026
Merged

Add PlayStation disc profiles#444
superg merged 1 commit into
superg:mainfrom
Deterous:psdrive

Conversation

@Deterous

@Deterous Deterous commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

PlayStation 3/4 OEM drives return non-standard values for PlayStation discs.
By adding these profiles to redumper, it will correctly detect and dump PlayStation discs when dumping with PS3/PS4 drives connected to PC, or when dumping on-console (such as with PS4 Linux).

PS5 console/drive is not yet tested, so not sure what PS5 drives or discs do (extrapolating would be 0xFF90 for PS5 discs but won't add until someone tests it).

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0c71d826-70ba-43d7-90ad-fd8771f9bec5

📥 Commits

Reviewing files that changed from the base of the PR and between f01a786 and 97c72e0.

📒 Files selected for processing (2)
  • redumper.ixx
  • scsi/mmc.ixx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change adds six PlayStation optical-disc profiles, display strings, and mappings to CD, DVD, or BLURAY.

Changes

PlayStation optical-disc profiles

Layer / File(s) Summary
Add PlayStation profile codes
scsi/mmc.ixx
The exported profile enumeration now defines six PlayStation-specific profile codes.
Map profiles to display names and disc types
redumper.ixx
The new profiles receive display strings and resolve to their corresponding disc types.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 97c72

This adds PlayStation disc-profile recognition and routes each supported format to its existing CD, DVD, or Blu-ray handling path. No current merge-blocking risk remains.

Suggested reviewers: superg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding PlayStation disc profiles.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superg

superg commented Sep 10, 2026

Copy link
Copy Markdown
Owner

How did you verify this?

Also, PS3 has CD discs as well.
Did you try both DVD-5 and DVD-9.
Did you try audio CD etc?
I wonder if it would be better if we find the complete enumeration, might be available from some PS3 reverse engineering sources.

@Deterous

Deterous commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

PS4 BD value is from the recent issue dumping on PS4 Linux, someone in VGPC has logs.
The other values are from my notes when I was using 3k3y + PS3 drive on PC.

Standard CDs like Audio CDs have normal profile values from what I can remember, these new values are only for PlayStation discs.

PS3 has CD-ROM support but I don't know of any official ones (most are just burned CD-R), plus the enumeration seems to be logical (2nd to last digit is the PS generation and last digital increments from 0)

@superg
superg merged commit 1704af3 into superg:main Sep 10, 2026
11 checks passed
@Deterous
Deterous deleted the psdrive branch September 12, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants