Skip to content

BDXL channel lengths - #446

Merged
superg merged 1 commit into
superg:mainfrom
Deterous:channel-bit
Sep 12, 2026
Merged

BDXL channel lengths#446
superg merged 1 commit into
superg:mainfrom
Deterous:channel-bit

Conversation

@Deterous

@Deterous Deterous commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

From ISO 30191
image

Summary by CodeRabbit

  • Bug Fixes
    • Updated Blu-ray channel-length data for two previously unspecified entries.
    • Removed obsolete reserved entries from the channel-length lookup data.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ba5739bd-d488-4034-9149-1e3377f68a19

📥 Commits

Reviewing files that changed from the base of the PR and between 1704af3 and 739a5ff.

📒 Files selected for processing (1)
  • dvd/dvd_dump.ixx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Blu-ray channel length lookup table now includes two previously blank values and no longer contains the trailing reserved12 and reserved13 entries.

Changes

Blu-ray channel length table

Layer / File(s) Summary
Update channel length mappings
dvd/dvd_dump.ixx
The table fills indices 4 and 5 with 58.26nm and 55.87nm, then ends at reserved11.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: superg

Merge Risk: ⚪ Minimal · up to 739a5

This is a limited lookup-table update with no identified correctness, integrity, security, or availability risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: updating BDXL channel lengths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@superg
superg merged commit 644853f into superg:main Sep 12, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants