Skip to content

feat: adds doctor preflight checks.#153

Open
karlzierhofer wants to merge 15 commits into
mainfrom
feature/doctor
Open

feat: adds doctor preflight checks.#153
karlzierhofer wants to merge 15 commits into
mainfrom
feature/doctor

Conversation

@karlzierhofer
Copy link
Copy Markdown
Contributor

@karlzierhofer karlzierhofer commented Feb 6, 2026

Why

Improve preflight diagnostics and first-run resilience, and keep configuration rendering deterministic by resolving required values during init instead of mutating rendered config during deploy.
In addition, document the overlapping-pipeline commit race clearly while waiting for an upstream LZA fix.

What

  • Added a doctor preflight command with actionable output.
  • deploy runs doctor automatically and aborts on failures (--skip-doctor available).
  • Added fixture mode for offline doctor output reproduction.
  • Added a quotas command to request Lambda concurrency quota increases (--dry-run supported, skips already pending requests).
  • Moved Control Tower CloudTrail log group resolution to init and rendered it directly into config output.
  • Added init prechecks to validate rollout readiness (including finalize marker checks with region fallback behavior).
  • Added/updated regression tests for init, doctor, and deploy failure paths.
  • Added detailed runbook documentation for the overlapping execution commit-race analysis and linked it from common issues.

Doctor checks

  • AWS account matches managementAccountId
  • Installer version (SSM) matches awsAcceleratorVersion
  • Installer stack exists
  • Config bucket exists
  • CDK assets buckets exist for all enabledRegions
  • Lambda concurrency meets minLambdaConcurrency across enrolled accounts/regions
  • LZA checkout exists and branch matches awsAcceleratorVersion

@karlzierhofer karlzierhofer force-pushed the feature/doctor branch 12 times, most recently from f4a50a2 to cdf35e9 Compare February 11, 2026 15:28
@karlzierhofer karlzierhofer marked this pull request as ready for review February 12, 2026 17:16
@karlzierhofer karlzierhofer requested a review from a team as a code owner February 12, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant