Skip to content

Conversation

@nexxeln
Copy link
Member

@nexxeln nexxeln commented Jan 27, 2026

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 2715386 Jan 27 2026, 04:27 PM

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
supermemory-app 2715386 Jan 27 2026, 04:23 PM

@nexxeln nexxeln marked this pull request as ready for review January 27, 2026 16:23
@graphite-app graphite-app bot requested a review from Dhravya January 27, 2026 16:23
Copy link
Member Author

nexxeln commented Jan 27, 2026


How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Jan 27, 2026

Code review

I found one issue that needs attention:

Missing dependency in useCallback

File: apps/web/components/new/memories-grid.tsx
Line: 314 (dependency array)

The selectedProject variable is used inside the renderItem callback on line 286:

containerTags={selectedProject ? [selectedProject] : undefined}

However, selectedProject is missing from the useCallback dependency array (lines 307-314). This will cause a stale closure bug where the GraphCard will continue to use an old value of selectedProject even after it changes.

Fix: Add selectedProject to the dependency array:

  [
    handleCardClick,
    quickNoteProps,
    highlightsProps,
    documents,
    isPending,
    error,
    selectedProject,  // Add this
  ]

Reference:

<div className="p-2" style={{ width }}>
<GraphCard
containerTags={selectedProject ? [selectedProject] : undefined}
width={width - 16}
height={220}


Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants