Feat: Add organization name to setup flow#4874
Open
shyamsalimkumar wants to merge 5 commits into
Open
Conversation
|
👋 Commands for maintainers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Demo)Why
Self-hosted instances were always created with the organization name
Demowith no way to change it during setup. Fine for single-command turbo installs, but not acceptable for real self-hosted deployments as mentioned in #1665How
Organization name field
organization_nametoSetupOwnerRequeston the backend; if absent, defaults to"Demo"so existing integrations and the turbo install path are unaffectedautoComplete="organization"to prevent browsers autofilling a city nameTest infrastructure fixes
noValidateto the owner step form — without it, jsdom's HTML5type="email"constraint validation blocks form submit before React's custom validation runs, making the invalid-email test untestableResizeObserverstub to the global test setup — Radix UI'sCheckboxcomponent (used in the SMTP config step) callsnew ResizeObserver()on mount and crashes in jsdom without itNew tests
organization_namepayload, error handling, and 409 conflict)Breaking changes
None.
organization_nameis optional on the API — omitting it falls back to"Demo".