fix: TypeError: P.substring is not a function in grafana mappers

[cursor]

Summary

Fix TypeError: P.substring is not a function Sentry crash caused by calling .substring() directly on configuration.text / configuration.comment values inside several Grafana canvas-node mappers. When the API returns a non-string value (number, object, array) for these fields, .substring() throws and the canvas degrades to the Can't display fallback.

This is a follow-up to #4005, which introduced the safe truncate() utility in safeMappers.ts and migrated most mappers to use it — but missed the Grafana annotation / silence / incident files.

Sentry

• Issue: https://superplane.sentry.io/issues/7503631194/
• Title: TypeError: P.substring is not a function
• First seen: 2026-05-24
• Culprit: ?(assets/index-D-SN1A9B) (minified bundle, P = some non-string config value)

Changes

• grafana/create_silence.ts — use truncate(configuration.comment, 60) instead of configuration.comment.substring(...).
• grafana/create_annotation.ts — use truncate(configuration.text, 80 / 50) in both getExecutionDetails and the metadata builder.
• grafana/list_annotations.ts — use truncate(configuration.text, 50 / 80) and replace the local truncateText(value: string, …) helper (which would throw on non-strings) with the safe truncate() from safeMappers.
• grafana/incident_shared.ts — relax the local truncate(value) to accept unknown and coerce to string before calling .substring, mirroring safeMappers.truncate.

Tests

• Extend grafana/annotations.spec.ts with regression tests for createAnnotationMapper and listAnnotationsMapper exercising non-string configuration.text and a non-string latest.text in output payloads.
• New grafana/silences_and_incident_shared.spec.ts covering createSilenceMapper with non-string configuration.comment (number / object) and the incident_shared.truncate helper for nullish, primitive, and object inputs.

Notes

• These mappers are still wrapped by createSafeComponentMapper, but per the precedent in fix: TypeError: z.substring is not a function #4005 the proper fix is to prevent the throw entirely so the node renders normally instead of falling back to Can't display.

  

[superplanehq-integration]

👋 Commands for maintainers:

• /sp start - Start an ephemeral machine (takes ~30s)
• /sp stop - Stop a running machine (auto-executed on pr close)