Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions web_src/src/pages/workflowv2/WorkflowFilesOverlayLayer.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,28 @@ describe("WorkflowFilesOverlayLayer", () => {
useSidebarLayoutStore.getState().hydrateFromStorage();
});

it("opens the first file when files load after the overlay mounts", () => {
const { rerender } = render(<WorkflowFilesOverlayLayer isFilesMode files={[]} />);

expect(screen.queryByTestId("monaco-stub")).not.toBeInTheDocument();

rerender(
<WorkflowFilesOverlayLayer
isFilesMode
files={[
{
path: "canvas.yaml",
content: "canvas: true",
language: "yaml",
},
]}
/>,
);

expect(screen.getByRole("button", { name: "Close canvas.yaml" })).toBeInTheDocument();
expect(screen.getByTestId("monaco-stub")).toHaveTextContent("canvas: true");
});

it("keeps all editor tabs closed after closing the last tab", async () => {
const user = userEvent.setup();

Expand Down
22 changes: 16 additions & 6 deletions web_src/src/pages/workflowv2/WorkflowFilesOverlayLayer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,27 @@ function CanvasYamlFilesView({ files }: { files: WorkflowFile[] }) {
const filePaths = useMemo(() => files.map((file) => file.path), [files]);
const [selectedPath, setSelectedPath] = useState<string | null>(() => filePaths[0] ?? null);
const [openTabs, setOpenTabs] = useState<string[]>(() => (filePaths[0] ? [filePaths[0]] : []));
const previousFileCountRef = useRef(filePaths.length);
const selectedFile = files.find((file) => file.path === selectedPath) ?? null;

useEffect(() => {
const filePathSet = new Set(filePaths);
const filesLoaded = previousFileCountRef.current === 0 && filePaths.length > 0;
const nextOpenTabs = openTabs.filter((path) => filePathSet.has(path));
const ensuredOpenTabs = filesLoaded && nextOpenTabs.length === 0 ? [filePaths[0]] : nextOpenTabs;
const nextSelectedPath =
selectedPath && filePathSet.has(selectedPath) ? selectedPath : (ensuredOpenTabs[0] ?? null);

setOpenTabs((current) => {
const nextTabs = current.filter((path) => filePathSet.has(path));
return nextTabs.length === current.length ? current : nextTabs;
});
setSelectedPath((current) => (current && filePathSet.has(current) ? current : null));
}, [filePaths]);
previousFileCountRef.current = filePaths.length;

if (ensuredOpenTabs.length !== openTabs.length || ensuredOpenTabs.some((path, index) => path !== openTabs[index])) {
setOpenTabs(ensuredOpenTabs);
}

if (nextSelectedPath !== selectedPath) {
setSelectedPath(nextSelectedPath);
}
}, [filePaths, openTabs, selectedPath]);

const openFile = (path: string) => {
setSelectedPath(path);
Expand Down