Fix prices missing when products are restored from cache - #458
Merged
Conversation
ianrumac
force-pushed
the
ir/fix/product-name-serde
branch
from
September 7, 2026 11:54
43d5d10 to
e3c3aa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Cached config writes product reference names as
product, but the decoder only readreference_name. Restoring config therefore turned names such asofferinto empty strings, leaving prices unavailable to named paywall bindings. Accept both fields, preferring the API'sreference_name, so existing caches restore correctly without changing the WebView payload.Adds serialization, request-cache/template, and Android WebView regression tests, plus an Unreleased changelog entry.
Validation
€23.99.ProductItem.kt.Checklist
CHANGELOG.md.