🔄 Sync supportpal/addon-language-english#12
Open
bytestream wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR synchronizes language files from the supportpal/addon-language-english repository. It includes organizational changes and fixes to French translation files.
- Reorganizes the "published_desc" translation entry to be grouped with version 5.7.5 additions
- Adds a new "not_published" translation key for version 5.7.5
- Fixes JavaScript variable placeholder escaping in the search results string
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Lang/fr/selfservice.php | Moves "published_desc" translation to version 5.7.5 section and adds "not_published" translation key |
| Lang/fr/core.php | Fixes escaped dollar sign in "multiple_search_results" to properly support JavaScript variable interpolation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * 5.7.5 | ||
| */ | ||
| "published_desc" => "Si l'article peut être consulté publiquement. Si il n'est pas publié, il peut encore être vu par l'URL directe si la catégorie est publique.", | ||
| "not_published" => "Not Published", |
There was a problem hiding this comment.
The translation value "Not Published" is in English but should be translated to French. This is a French language file (Lang/fr/), so all translation values should be in French. Consider translating to "Non publié" or similar.
Suggested change
| "not_published" => "Not Published", | |
| "not_published" => "Non publié", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced files with supportpal/addon-language-english.
This PR was created automatically by #19891022540