Skip to content

Fix cache manager types #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sur950 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix cache manager types #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/src/helpers/cache_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@ import 'package:flutter/material.dart';
import 'package:shared_preferences/shared_preferences.dart';

class CacheManager {
static Future getJson({required String key}) async {
dynamic cache;
static Future<Map<String, dynamic>?> getJson({required String key}) async {
String? cache;
try {
final sharedPreferences = await SharedPreferences.getInstance();
cache = sharedPreferences.getString(key);
} catch (e) {
debugPrint('Cache URL had a change => $e');
}
dynamic jsonMapCache;
Map<String, dynamic>? jsonMapCache;
if (cache != null) {
jsonMapCache = jsonDecode(cache) as Map<dynamic, dynamic>;
jsonMapCache = jsonDecode(cache) as Map<String, dynamic>;
}
return jsonMapCache;
}
Expand All @@ -25,12 +25,11 @@ class CacheManager {
.whenComplete(() => (takeAction as void Function()?)?.call());
}

static Future setJson({
static Future<void> setJson({
required String key,
required Map<dynamic, dynamic> value,
required Map<String, dynamic> value,
}) async {
final sharedPreferences = await SharedPreferences.getInstance();
var jsonMap = value;
await sharedPreferences.setString(key, jsonEncode(jsonMap));
await sharedPreferences.setString(key, jsonEncode(value));
}
}
3 changes: 2 additions & 1 deletion lib/src/helpers/link_analyzer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ class LinkAnalyzer {
Metadata? info_;

try {
final infoJson = await CacheManager.getJson(key: url);
final Map<String, dynamic>? infoJson =
await CacheManager.getJson(key: url);
if (infoJson != null) {
info_ = Metadata.fromJson(infoJson);
var isEmpty_ = info_.title == null || info_.title == 'null';
Expand Down