breaking: remove stores and other todos#15499
Conversation
🦋 Changeset detectedLatest commit: 26f9ff7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
teemingc
changed the title
teemingc
changed the title
| /* global ENV_PREFIX */ | ||
| /* global PRECOMPRESS */ |
There was a problem hiding this comment.
The globals are already declared in index.d.ts
| } | ||
| mounted = true; | ||
| return unsubscribe; | ||
| initialised = true; |
There was a problem hiding this comment.
Had a choice of doing if(untrack(() => mounted)) or having this non-reactive flag so that we only announce routes after the first time page is updated. Seemed better to not import untrack when declaring this simple flag is cheaper
| "test:others": "pnpm -r --filter='./packages/*' --filter=!./packages/kit/ --workspace-concurrency=1 test", | ||
| "check": "pnpm -r prepublishOnly && pnpm -r check", | ||
| "lint": "pnpm -r lint && eslint --cache --cache-location node_modules/.eslintcache 'packages/**/*.js'", | ||
| "lint": "pnpm -r lint && echo '\nRunning eslint...' && eslint --cache --cache-location node_modules/.eslintcache 'packages/**/*.js'", |
There was a problem hiding this comment.
ESLint doesn't output anything when it starts or after a successful run. This placeholder message helps because I thought the linting was frozen after it ran prettier checks in each directory but the process hadn't exited yet.
packages/kit/tsconfig.json
Outdated
| "target": "es2023", | ||
| "module": "node16", | ||
| "moduleResolution": "node16", | ||
| "target": "esnext", |
There was a problem hiding this comment.
Had to change this to get the types for Promise.withResolvers(). Not sure what the effect is on our types generation
1 participant
closes #15406
requires sveltejs/svelte.dev#1845 to be merged for docs to build successfully
This PR tries to resolve a bunch of TODOs we had for Kit 3, including removing:
$app/stores-base,assets, andresolveRoutefrom$app/paths-builder.createEntriesnavigation.deltafor non-popstate navigations- Pre-Node 22 workarounds such as a util to replacePromise.withResolvers()Some thoughts:
EDIT: split some changes into other PRs to make this one smaller
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits