Replace the manual Real AudioV4 field sequence with generated serial tables - #758
Merged
swackhamer merged 4 commits intoSep 13, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
swackhamer
deleted the
codex/real-v4-retirement-integration-20260913
branch
September 13, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real AudioV4 copied a 31-slot field sequence into its parser. This change removes that sequence and reads the source-generated AudioV4 descriptor through the shared serial reader from #757. The carrier retains signature/version selection and the native 512-byte bounded read.
The shared behavior also corrects legacy output: native UTF-8 question-mark repair fixes Copyright on the real sample, strings stop at NUL, and an incomplete Artist span no longer invents later Copyright/Comment fields. Version 3/5 activation, native warnings and the existing group-0/group-2 occurrence limits remain explicit residuals.
Validation completed locally:
The complete paired 4,238-file census is independently accepted. With unchanged conformance.py scoring and pinned ExifTool 13.59, correct rows rise 468,086 -> 468,087 and VALUE differences fall 421 -> 420; MISSING 12,240 / RENAME 22 / EXTRA 1,560 are unchanged. The only raw or scored per-file change is Real.ra Copyright now matching native question-mark repair; the other 4,237 files are unchanged. All input hashes are stable and there are zero parse/crash failures. Raw stdout/stderr and exits are retained for all three tools on every file.
The supervisor returns 1 because native ExifTool reports
File is emptyfor the pre-existing zero-byte FujiFilmISPro.jpg. That parsed diagnostic row remains in the denominator; both OxiDex builds exit 0 with identical meaningful output. Independent review accepts this documented diagnostic separately from new failures. Full pair elapsed 273.168 seconds. Production source at PR head is identical to the measured candidate; subsequent Rust changes add only regression assertions.All five required hosted checks passed at
4bcda9d9: 757 canonical Python tests with zero failures/skips in 643.545 seconds; nextest 5,761 passed with 59 intentional skips; complete Cargo test/doc and explicit native replay passed. Benchmarks were intentionally skipped. This PR claims no new project autogenerated percentage; count the manual reader and 31-slot sequence as retired only after acceptance and landing.