Skip to content

add support github.com/swaggo/swag/v2 - #125

Merged
ubogdan merged 5 commits into
swaggo:masterfrom
martinyonatann:feat/support-v3
Sep 11, 2025
Merged

ubogdan merged 5 commits into
swaggo:masterfrom
martinyonatann:feat/support-v3

Conversation

@martinyonatann

@martinyonatann martinyonatann commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

Describe the PR
add support github.com/swaggo/swag/v2

Relation issue
Address issue #126

Additional context
N/A

@martinyonatann martinyonatann changed the title add support swaggo v2 add support github.com/swaggo/swag/v2 Feb 2, 2025
@martinyonatann

Copy link
Copy Markdown
Contributor Author

please help to review @ubogdan

@ubogdan

ubogdan commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Merging this into the master branch will force everyone to generate the "doc" with swag v2. This will introduce breaking changes to all projects using v1 (echo-swagger).

@martinyonatann

Copy link
Copy Markdown
Contributor Author

Merging this into the master branch will force everyone to generate the "doc" with swag v2. This will introduce breaking changes to all projects using v1 (echo-swagger).

I don't think so. V1 is still using the existing handler, while V2 uses EchoWrapHandlerV3.

@martinyonatann

Copy link
Copy Markdown
Contributor Author

github.com/sv-tools/openapi only supports Go 1.21 or newer. Do we need to upgrade as well? I think 1.16 is too old.

@zuramai

zuramai commented May 8, 2025

Copy link
Copy Markdown

any update?

@martinyonatann

Copy link
Copy Markdown
Contributor Author

i will close the PR if the maintainer thinks the PR is useless.

cc @ubogdan

any update?

@ubogdan

ubogdan commented Sep 6, 2025 via email

Copy link
Copy Markdown
Contributor

@ubogdan

ubogdan commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

@martinyonatann Looks goot to me , please resolve conflicts.

@martinyonatann

Copy link
Copy Markdown
Contributor Author

@martinyonatann Looks goot to me , please resolve conflicts.

Conflict resolved. @ubogdan

@ubogdan ubogdan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
ubogdan merged commit 85c1812 into swaggo:master Sep 11, 2025
7 checks passed
@martinyonatann
martinyonatann deleted the feat/support-v3 branch February 17, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants