Add Proof Key for Code Exchange support - #149
Open
frederikmillingpytlick wants to merge 1 commit into
Open
frederikmillingpytlick wants to merge 1 commit into
frederikmillingpytlick wants to merge 1 commit into
Conversation
frederikmillingpytlick
changed the title
Author
|
@ubogdan perhaps you could take a look when you get the time? :) |
frederikmillingpytlick
force-pushed
the
feature/pkce-v1
branch
from
August 6, 2026 06:49
aaf588a to
72981d2
Compare
Restore PKCE support needed for Keycloak authorization-code clients. Based on upstream PR swaggo#100 (closed unmerged). Branch is based on v1.5.2 (module github.com/swaggo/echo-swagger, Echo v4) so it remains usable as a replace target for Echo v4 consumers.
frederikmillingpytlick
force-pushed
the
feature/pkce-v1
branch
from
August 6, 2026 06:53
72981d2 to
973446c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Similar to the issue #243 in the gin-swagger repo, and swaggo/swag#871:
Is your feature request related to a problem? Please describe.
OAuth2 clients that only support Authorization Code Flow with PKCE do not work with the current feature set of echo-swagger.
Describe the solution
Add Proof Key for Code Exchange support. There is a flag for it in Swagger UI 3.24.0+. The flag in Swagger UI is
usePkceWithAuthorizationCodeGrant.In the corresponding Pull Request I added an additional attribute to the OAuthConfig struct called "UsePkce" which configures the boolean parameter for "usePkceWithAuthorizationCodeGrant" in the "initOAuth" part of the index template.
With this small change, the auth flow works as expected.
Relation issue
#99