Skip to content

fix: ignore line comments in parser diagnostics - #308

Open
swananan wants to merge 1 commit into
mainfrom
fix/ignore-comments-in-parser-diagnostics
Open

swananan wants to merge 1 commit into
mainfrom
fix/ignore-comments-in-parser-diagnostics

Conversation

@swananan

@swananan swananan commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • stop the unknown-keyword heuristic at // comment boundaries outside strings
  • preserve // inside grammar-valid trace file paths by validating the parsed trace_pattern and file_path span
  • preserve the underlying Pest diagnostic for real syntax errors after commented lines
  • add regressions for comma-containing comments and repeated slashes in trace paths

Testing

  • cargo fmt --all -- --check
  • cargo test -p ghostscope-compiler (185 passed)
  • cargo clippy --all-targets --all-features -- -D warnings
  • standard host-to-host e2e via runner job 8cab17c08bea (exit code 0)

Container-topology e2e was intentionally skipped because this parser-only change does not affect container behavior, PID namespaces, sandbox topology, Docker execution, or runner semantics.

@swananan
swananan force-pushed the fix/ignore-comments-in-parser-diagnostics branch from 1e471ac to 53c1bd7 Compare September 14, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant