Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions P3_assigned-feedback.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
## P3 Assigned Feedback

Overall
Interesting website addressing a real-world issue. Creative web tab icon to match your theme. I have little in the way of constructive feedback, but I learned from your coding style. Specifically, the way you broke down the code organization and your commenting was helpful.

---

### Overall Organization
The file structure is clear and well-organized. The selected names were clear and helped me understand the overall function of each aspect.

The page nesting was organized but required entering many folders to see the code. Consider less nesting and using naming conventions to see the bigger picture.
I liked the color matching of the membership levels.

---

### README.md
Clear and informative. Your descriptions were at a level I could understand. It was interesting how you chose to populate the database with 1000 records. I will need to look more at that! The available script section was helpful, and I like the table format.

---

### DB Files
I like the way you broke up the db files by function, and the comments help me understand each step in the code. For example, the config.js was separated and each of the db collections had another file.
I liked the way you used mapping to define a constant (db/dues-submissions-db.js), i.e., submission status.

---

### Frontend files
I liked your use of the WidgetCard component, which was used in the MembersPage.jsx file.

---

### Middleware Files
Interesting use of club member leveling.

---

### Routes Files
No additional feedback on routes.