Vasilios Nicholas Peer Review for Final Project

[vasiliosnicholas]

Vasilios Nicholas Code Review

Overall great job with the app! I think the user roles are well-defined, making the app functional for end-users. I like how you can export the data per club as a CSV file. However, I would recommend making the dues tier list configurable to the admin user role, such that they can customized the # of tiers and the names of tiers. Also it might make sense to have the price per "due" tier to be part of an event as different events most likely will have different costs for the club to host.
I would also add a manage dues page to edit the price of the tiers in case a mistake was made during initial entry.

I appreciated the thorough commenting throughout the codebase but would recommend using JSDOC's instead of inline comments or regular multiline comments. Also would recommend moving some business logic to the backend (like handling authorization for certain routes.)

I would recommend better form validation as I was able to set my date of birth for a future date and each time I attempted to submit the form with errors, I was brought to the first invalid form input, but the actual error was only displayed at the bottom of the form. Also, it appears that only the first error in the stack is displayed, instead of diplaying all errors concurrently. I would recommend displaying form errors for each field/input concurrently and have each field error ajacent to the field in question. The latter appears to be an issue accross all forms I tried.

Commits:

• Add praise for middlware factory function for authorization
• Add question about error handling
• Added comment about moving authorization logic to backend
• Add praise for use of useContext hook for authentication
• semantic html - title and meta elements are not permitted outside of head element + instructions to fix