fix: issue-4 implementation - #7
dragonfruit-blue wants to merge 2 commits into
Conversation
anomolous-lemur
left a comment
anomolous-lemur
left a comment
There was a problem hiding this comment.
Thanks for the PR, @dragonfruit-blue -- just a few minor comments below.
| __pycache__/ | ||
| *.pytest_cache/ | ||
|
|
||
| data/* No newline at end of file |
There was a problem hiding this comment.
This change is out-of-place in this PR.
| // } | ||
|
|
||
| // Apply angle mode transformations for angle dimensions | ||
| if (Type.isValue("Angle") || Type.isValue("Angle3Pt")) { |
There was a problem hiding this comment.
You're missing the else clause here - the original code negated things that were marked as Inverted but were not "Angle" or "Angle3Pt".
| // if (Inverted.getValue()) { | ||
| // if (Type.isValue("Angle") || Type.isValue("Angle3Pt")) { | ||
| // result = CircleDegrees - result; | ||
| // } | ||
| // else { | ||
| // result = -result; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Drop all of the commented out code blocks.
|
Thanks for the changes -- .gitignore is still touched. Do you need help removing that change from this PR? |
|
Thanks for helping improve FreeCAD! If the PR is still relevant, let us know by adding a comment. If you would like to keep working on this pull request, we advice to rebase it on current main branch, ask feedback from users or maintainers and engage with the community to get it forward. |
2 participants
##Summary
This PR implements the changes required for issue #4.
##Changes
Issues
Closes #4