Gui: redesign Macros dialog layout for clarity - #8
dragonfruit-blue wants to merge 1 commit into
Conversation
Reorganize the Macros dialog (formerly "Execute Macro") to more effectively guide users through the available actions: - Rename window title from "Execute Macro" to "Macros" - Remove confusing "Macro Name" group box wrapper - Move search fields (Find file, Find in files) to a clean top row - Place "Selected:" label inline below the macro list - Reorder button column: Execute (primary) → Create/Edit/Rename/ Duplicate/Delete (file management) → Toolbar/Download (secondary) → Close (bottom), with visible separator lines between groups - Fix tab bar clipping by enforcing min-width on each tab Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for the PR, @dragonfruit-blue -- could you please include before-and-after images in the PR writeup? |
| <property name="sizeType"> | ||
| <enum>QSizePolicy::Expanding</enum> | ||
| <property name="styleSheet"> | ||
| <string>QLabel { background-color: #aaaaaa; }</string> |
There was a problem hiding this comment.
Don't hardcode colors like this -- it will conflict with dark mode (or light mode, or whatever theme the user has selected).
| <number>4</number> | ||
| </property> | ||
| <property name="styleSheet"> | ||
| <string>QLabel { background-color: #aaaaaa; }</string> |
| </widget> | ||
| </item> | ||
| <item> | ||
| <widget class="QLabel" name="line2"> |
There was a problem hiding this comment.
Are these the gray bars that are separating the different groups of buttons? Those are not a standard user-interface element in FreeCAD -- instead, just use a small spacer, don't try to color it.
| <property name="text"> | ||
| <string>Download</string> | ||
| <string>Close</string> |
There was a problem hiding this comment.
I don't think a Close button is needed in this dialog. It's already quite cluttered, and it's not actually really clear what "Close" means in this context.
|
Thanks for helping improve FreeCAD! If the PR is still relevant, let us know by adding a comment. If you would like to keep working on this pull request, we advice to rebase it on current main branch, ask feedback from users or maintainers and engage with the community to get it forward. |
2 participants
Summary
No
.cppchanges — all widget object names are preserved, so all existing signal/slot connections and logic remain intact.Test plan
🤖 Generated with Claude Code