Add pydantic field descriptions in prompts - #14
Open
banana-bison wants to merge 2 commits into
Open
banana-bison wants to merge 2 commits into
banana-bison wants to merge 2 commits into
Conversation
Signed-off-by: banana-bison <bananabison@gmail.com>
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
| def extract_pydantic_field_descriptions( | ||
| model_class: type, | ||
| max_depth: int = 3, | ||
| _visited: set | None = None, |
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
| Returns: | ||
| Formatted string with field descriptions | ||
| """ | ||
| from pydantic import BaseModel |
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
| args = get_args(annotation) | ||
| return any(is_pydantic_model(arg) for arg in args) | ||
|
|
||
| except (TypeError, ImportError): |
Collaborator
There was a problem hiding this comment.
Which part do we expect to fail?
Author
There was a problem hiding this comment.
issubclass could raise an exception for inputs such as issubclass(Any, BaseModel). But since this is an internal function, I guess this is a little too defensive. I can remove it.
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
TomeHirata
reviewed
Mar 8, 2026
Collaborator
|
Can we describe what the current prompt looks like and what it should be in the PR description? |
Signed-off-by: banana-bison <bananabison@gmail.com>
Author
|
@TomeHirata i've address all the comments and updated the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5
In case of a pydantic description such as this:
The LLM would see a description like this:
Earlier it could see just
person, not the nested fields that it contains.