Add support for Cache-Control in Directory and File HTTPHandler#194
Merged
swhitty merged 4 commits intoswhitty:mainfrom Apr 1, 2026
Merged
Add support for Cache-Control in Directory and File HTTPHandler#194swhitty merged 4 commits intoswhitty:mainfrom
swhitty merged 4 commits intoswhitty:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 92.80% 92.39% -0.42%
==========================================
Files 68 69 +1
Lines 3448 3536 +88
==========================================
+ Hits 3200 3267 +67
- Misses 248 269 +21 ☔ View full report in Codecov by Sentry. |
6993b14 to
463cf9b
Compare
463cf9b to
35a3a6b
Compare
Contributor
Author
|
Hey @swhitty , what are your thoughts on this? |
swhitty
reviewed
Apr 1, 2026
|
|
||
| static func getETagValue(for data: Data) -> String? { | ||
| #if canImport(CryptoKit) | ||
| let sha256digest = SHA256.hash(data: data) |
Owner
There was a problem hiding this comment.
there is a cross platform SHA1 implementation in this repo that could be used instead — or at least used on other platforms without CryptoKit.
Even though SHA1 is not secure I don't think it matters for eTags really especially in the context of this DirectoryHTTPHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: