Add parameterLabel modifier for argument labels in semantic tokens #2395
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomInTheWire
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
PhantomInTheWire
force-pushed
the
feat/add-parameterLabel-modifier
branch
from
02d3446 to
80f905b
Compare
ahoppen
reviewed
Dec 19, 2025
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Nice. Looks good to me, I’d just like to define the modifier in swift-tools-protocols.
| extension SemanticTokenModifiers { | ||
| // Argument labels are considered part of the function name, but this modifier | ||
| // allows themes to style them differently if desired. | ||
| package static var parameterLabel: Self { Self(rawValue: UInt32(1) << UInt32(SemanticTokenModifiers.all.count)) } |
Member
There was a problem hiding this comment.
Could you add this to the definition of SemanticTokenModifiers in swift-tools-protocols?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Argument labels are currently tokenized as function without any modifier, making them indistinguishable from function names. This prevents theme authors from styling them differently, particularly important for accessibility (e.g., themes for neurodivergent developers) and personal preference.
Changes:
Fixes #1540