Show "Platforms" eyebrow and match nav display name on landing page - #51
Merged
Merged
Conversation
This module belongs to the "Platforms" nav group in the combined
docs site, but the landing page showed no eyebrow above the title,
and its display name ("Swift for Android") didn't match the "Android"
label used in that nav.
Member
|
Thanks, we don't have any code owners set up yet, so I believe nobody was notified about this: I just happened to check on this repo. |
Member
|
@swiftlang/android-workgroup, should we set up code owners for this repo? @heckj, can you review my website pull for Android? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@TitleHeading("Platforms").@DisplayNamewas "Swift for Android", while the nav label is "Android". Updates the display name to match so the in-content title agrees with the nav.Test plan
swift package generate-documentation --target SwiftAndroid --analyze --warnings-as-errorsbuilds cleanly (no new warnings)