Recognize actor (distributed) methods and extensions as Async functions - #895
Merged
Conversation
…c` to handle them as async during conversion.
AbdAlRahmanGad
force-pushed
the
actor-methods
branch
from
August 19, 2026 12:53
ffcf85f to
af8fd89
Compare
ktoso
reviewed
Aug 20, 2026
Collaborator
|
Also a test with a |
AbdAlRahmanGad
marked this pull request as ready for review
August 20, 2026 10:04
AbdAlRahmanGad
changed the title
distributed) methods and extensions as Async functions
ktoso
reviewed
Aug 21, 2026
| import SwiftJava | ||
|
|
||
| public distributed actor DistributedHi { | ||
| public typealias ActorSystem = LocalTestingDistributedActorSystem |
Collaborator
There was a problem hiding this comment.
Yup that’s right! Sorry I didn’t send a complete snippet earlier
ktoso
approved these changes
Aug 21, 2026
ktoso
left a comment
ktoso
left a comment
Collaborator
There was a problem hiding this comment.
Logic and tests looking good, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #837