[SwiftExtract] Language-neutrality cleanup - #899
Merged
ktoso merged 1 commit intoAug 21, 2026
Merged
Conversation
Remove the Java/JNI specifics that leaked into the language-neutral analysis layer so other consumers (e.g. JavaScriptKit's BridgeJS) can adopt it without inheriting swift-java concepts: - Move SwiftQualifiedTypeName.jniEscapedName into JExtractSwiftLib. - Make the 'unresolved type' hint text injectable via a new SwiftExtractConfiguration.unresolvedTypeHint requirement (default nil); the swift-java Configuration keeps the existing --depends-on wording, so jextract diagnostics are unchanged. - Drop the unused swift-log dependency from the SwiftExtract target and its dead 'import Logging' statements; the module has its own logger.
Collaborator
|
All good changes, thank you! Really excited to start sharing the infra! |
ktoso
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Java/JNI specifics that leaked into the language-neutral analysis layer so other consumers (e.g. JavaScriptKit's BridgeJS) can adopt it without inheriting swift-java concepts:
SwiftQualifiedTypeName.jniEscapedNameinto JExtractSwiftLib.SwiftExtractConfiguration.unresolvedTypeHintrequirement (default nil); the swift-java Configuration keeps the existing--depends-onwording, so jextract diagnostics are unchanged.import Loggingstatements; the module has its own logger.