[SwiftExtract] Record the source file path on ExtractedFunc - #902
Draft
kateinoigakukun wants to merge 1 commit into
Draft
[SwiftExtract] Record the source file path on ExtractedFunc#902kateinoigakukun wants to merge 1 commit into
kateinoigakukun wants to merge 1 commit into
Conversation
ExtractedNominalType already exposes sourceFilePath, but functions did not carry theirs, so a consumer that groups output by input file (e.g. BridgeJS's per-file imported-API skeletons) could not attribute global functions or accessors to a file. Thread the path through the visitor into every ExtractedFunc; synthesized declarations keep nil.
kateinoigakukun
marked this pull request as draft
August 21, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractedNominalType already exposes sourceFilePath, but functions did not carry theirs, so a consumer that groups output by input file (e.g. BridgeJS's per-file imported-API skeletons) could not attribute global functions or accessors to a file. Thread the path through the visitor into every ExtractedFunc; synthesized declarations keep nil.
Depends on #900