[SwiftExtract] Make the analyzer instance API public and add resolveType - #903
Open
kateinoigakukun wants to merge 1 commit into
Open
Conversation
The static SwiftAnalyzer.analyze() entry point returns only the AnalysisResult, but some consumers need the analyzer itself after the run: type references can appear outside declaration signatures (e.g. in attribute arguments like '@JavaExport(as: Foo.self)' or BridgeJS's '@js(as: Foo.self)'), and resolving those requires the module's symbol tables. Make add(filePath:text:) and analyze(beforeProcessing...:) public so a consumer can drive an analyzer instance directly, and add resolveType(_:) to resolve a TypeSyntax against the analyzed module after analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static
SwiftAnalyzer.analyze()entry point returns only theAnalysisResult, but some consumers need the analyzer itself after the run: type references can appear outside declaration signatures (e.g. in attribute arguments like@JavaExport(as: Foo.self)or BridgeJS's@JS(as: Foo.self)), and resolving those requires the module's symbol tables. Makeadd(filePath:text:)andanalyze(beforeProcessing...:)public so a consumer can drive an analyzer instance directly, and addresolveType(_:)to resolve aTypeSyntaxagainst the analyzed module after analysis.