[stdlib] Add Unicode script data to scalar properties - #42227
Merged
Conversation
lorentey
requested changes
Apr 6, 2022
lorentey
left a comment
lorentey
left a comment
Member
There was a problem hiding this comment.
We must follow the Leading Underscore Rule when naming non-public interfaces, in every stdlib module.
Contributor
Author
oops forgot, thanks! |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
rxwei
approved these changes
Apr 7, 2022
forgot underscore part 2 add build rules back in for right now indents
Contributor
Author
|
@swift-ci please smoke test |
lorentey
approved these changes
Apr 8, 2022
Azoy
added a commit
to Azoy/swift
that referenced
this pull request
Jun 1, 2022
[stdlib] Add Unicode script data to scalar properties
Azoy
added a commit
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the
scriptandscriptExtensionsreturnUInt8because theUnicode.Scriptenum defined in the regex parser cannot be made SPI in the stdlib due to the fact that we bootstrap the regex parser using the system's SDK (which won't have this SPI symbol). We can teach the parser to store strings instead and define the enum here as SPI for the string processing module to turn it into the enum.This depends on swiftlang/swift-experimental-string-processing#255