Skip to content

Factorize detection merge#51

Merged
cleherny merged 8 commits into
ch/ex-dqry_postprocessingfrom
gs/factorize_ex_dqry
Sep 30, 2025
Merged

Factorize detection merge#51
cleherny merged 8 commits into
ch/ex-dqry_postprocessingfrom
gs/factorize_ex_dqry

Conversation

@GwenaelleSa
Copy link
Copy Markdown
Member

@GwenaelleSa GwenaelleSa commented Sep 11, 2025

No description provided.

@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@GwenaelleSa GwenaelleSa mentioned this pull request Sep 12, 2025
Merged
@GwenaelleSa GwenaelleSa self-assigned this Sep 12, 2025
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
cleherny
cleherny reviewed Sep 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@cleherny cleherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. It was sometimes difficult for my end of the week-fried brain to keep track of the changes, as some parts of the code were moved to other scripts, but I hope I didn't miss anything important. In any case, it looks good!
I made a couple of minor comments. At the same time, I also answered to your comments of PR #49.
I haven't looked in details at the data_augmentation part, so perhaps @acerioni could have a deeper look, along with all the changes of this PR.
I tested the quarry example and it works fine. I ran one test with the empty tiles and it seems fine. Have you fixed the issue of assigning empty tiles to another dataset?

Comment thread examples/anthropogenic-activities/config_trne.yaml Outdated
Comment thread helpers/functions_for_examples.py
Comment thread helpers/functions_for_examples.py Outdated
Comment thread scripts/generate_tilesets.py Outdated
Comment thread helpers/functions_for_examples.py
Comment thread examples/mineral-extract-sites-detection/config_trne.yaml Outdated
Comment thread README.md Outdated
Comment thread examples/anthropogenic-activities/README.md Outdated
Comment thread examples/anthropogenic-activities/README.md Outdated
Comment thread helpers/functions_for_examples.py
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube
Copy link
Copy Markdown

stdl-s-sonarqube Bot commented Sep 30, 2025

Passed

Analysis Details

3 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 3 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: swiss-territorial-data-lab_object-detector_AYZ4zWIzr7JdaaSXwexc

View in SonarQube

@cleherny cleherny merged commit 076fb64 into ch/ex-dqry_postprocessing Sep 30, 2025
1 check passed
@cleherny cleherny deleted the gs/factorize_ex_dqry branch September 30, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cleherny cleherny cleherny left review comments

Assignees

@GwenaelleSa GwenaelleSa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GwenaelleSa @cleherny