Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/middleware/limiter.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,20 @@ const ERROR_MESSAGE = {
error: 'API request per minute quota exceeded'
};

const getMaxRate = (rate_limit) => {
if (rate_limit === 0) {
return parseInt(DEFAULT_RATE_LIMIT);
}

return rate_limit;
};

export const DEFAULT_RATE_LIMIT = 1000;

export const defaultLimiter = rateLimit({
windowMs: DEFAULT_WINDOWMS,
limit: parseInt(process.env.MAX_REQUEST_PER_MINUTE || DEFAULT_RATE_LIMIT),
limit: getMaxRate(parseInt(process.env.MAX_REQUEST_PER_MINUTE)),
skip: (request) => request.rate_limit === 0,
standardHeaders: 'draft-7',
legacyHeaders: false,
message: ERROR_MESSAGE,
Expand Down
29 changes: 29 additions & 0 deletions tests/unit-test/limiter/app-limiter-set.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import mongoose from 'mongoose';
import request from 'supertest';

let app = null;

afterAll(async () => {
await new Promise(resolve => setTimeout(resolve, 1000));
await mongoose.disconnect();
});

beforeAll(async () => {
process.env.MAX_REQUEST_PER_MINUTE = 1;
app = (await import('../../../src/app')).default;
});

describe('When maximum request per minute is positive', () => {
test('LIMITER_SUITE - Should return 429 - Too many requests', async () => {
await request(app)
.get('/check')
.expect(200);

const req = await request(app)
.get('/check')
.expect(429);

expect(req.statusCode).toBe(429);
expect(req.body.error).toEqual('API request per minute quota exceeded');
});
});
22 changes: 22 additions & 0 deletions tests/unit-test/limiter/app-limiter-unlimited.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import mongoose from 'mongoose';
import request from 'supertest';

let app = null;

afterAll(async () => {
await new Promise(resolve => setTimeout(resolve, 1000));
await mongoose.disconnect();
});

beforeAll(async () => {
process.env.MAX_REQUEST_PER_MINUTE = 0;
app = (await import('../../../src/app')).default;
});

describe('When maximum request per minute is zero (unlimited)', () => {
test('LIMITER_SUITE - Should return 200 - OK', async () => {
await request(app)
.get('/check')
.expect(200);
});
});