Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request refactors the snapshot watching functionality to use a strongly typed callback class (
WatchSnapshotCallback) instead of a generic dictionary for handling success and error callbacks. This change improves type safety, code clarity, and maintainability across the codebase. The update affects the main client API, internal watcher logic, tests, and documentation.Refactoring to typed callback interface:
WatchSnapshotCallbackdataclass inswitcher_client/lib/snapshot_watcher.pyto replace the dictionary-based callback contract, providing explicitsuccessandrejecthandlers.Client.watch_snapshotand all related internal methods to accept and useWatchSnapshotCallbackinstead of a dictionary, ensuring type safety and clearer callback invocation. [1] [2] [3] [4]API and usage updates:
switcher_client/__init__.py,switcher_client/client.py, and all relevant files to expose and useWatchSnapshotCallback. [1] [2]README.mdand test/playground scripts to demonstrate the new callback interface. [1] [2] [3]Test suite migration:
tests/test_client_watch_snapshot.pyto useWatchSnapshotCallbackfor snapshot watching, ensuring coverage of the new interface and error handling. [1] [2] [3] [4]