[Fix/#99] 자녀 스티커 현황 조회 시 CHILD 유저만 반환하도록 필터링 추가

[yunmi-dev]

📌 관련 이슈

• close [Fix] 부모용 자녀 스티커 현황 조회 시 부모 역할 유저가 자녀로 조회되는 버그 #99

✨ 변경 사항

• getChildrenStickers에서 UserType.CHILD인 유저만 반환하도록 필터링 추가

📚 리뷰어 참고 사항

• 부모끼리 연결된 경우 자녀 스티커 현황에 노출되지 않아야 함

✅ 체크리스트

• 브랜치 전략(git flow)을 따랐나요?
• 로컬에서 빌드 및 실행이 정상적으로 되나요?
• 불필요한 주석이나 더미 코드는 제거했나요?
• 컨벤션(커밋 메시지, 코드 스타일)을 지켰나요?
• spotlessApply 실행했나요?

Summary by CodeRabbit

• Bug Fixes
  • Improved sticker filtering to accurately display only child user stickers, ensuring correct results are presented to users.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR fixes a bug in StickerQueryService where the getChildrenStickers method was returning all family relations instead of filtering to only those where the target user has UserType.CHILD, preventing parent-role users from being incorrectly included in children sticker queries.

Changes

Cohort / File(s)	Summary
Sticker Query Service Enhancement src/main/java/com/swyp/server/domain/sticker/service/StickerQueryService.java	Added filtering logic to getChildrenStickers method to exclude relations where target user is null or has UserType other than CHILD, preventing parent-role users from appearing in children sticker results. Added UserType import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• [Feat/#54] 부모용 자녀 스티커 현황 조회 API 구현 #64: Direct modification to the same StickerQueryService#getChildrenStickers method to narrow results based on target user type filtering.

Suggested reviewers

• guzzang
• SeHyeonCho

Poem

🐰 A filter was hiding, parents sneaked through!
In children's stickers where they shouldn't brew—
But now UserType checks what's really true,
Only CHILD roles pass, the bug's finally through! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding filtering to return only CHILD users when querying children stickers, directly addressing issue #99.
Linked Issues check	✅ Passed	The pull request implements the required filtering to return only UserType.CHILD users in getChildrenStickers, fully addressing the bug described in issue #99.
Out of Scope Changes check	✅ Passed	The changes are strictly focused on fixing the filtering issue in StickerQueryService.getChildrenStickers; no unrelated modifications are present.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/#99-children-sticker-role-filter

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}