Skip to content

release: align desktop release versions#149

Open
fettpl wants to merge 1 commit into
sybil-solutions:mainfrom
fettpl:fix/release-version-alignment-148
Open

release: align desktop release versions#149
fettpl wants to merge 1 commit into
sybil-solutions:mainfrom
fettpl:fix/release-version-alignment-148

Conversation

@fettpl

@fettpl fettpl commented Jun 20, 2026

Copy link
Copy Markdown

Summary

  • Applies semantic-release's computed nextRelease.version to root and frontend package metadata in the release workspace.
  • Adds a tested scripts/apply-release-version.mjs helper so Electron Builder sees the GitHub release version.
  • Documents semantic-release as the stable desktop release version source of truth in AGENTS.md.

Context

Addresses #148 and supports the Homebrew-readiness umbrella in #140.

The release bot does not commit package-version bumps to protected main. Package metadata is updated only in the GitHub Actions workspace before later desktop packaging steps.

Review Follow-up

  • Rebased onto current main after the Local Studio rename.
  • Preserved the deletion of CONTRIBUTING.md and moved the release-process paragraph into AGENTS.md.
  • Updated root test fixtures from vllm-studio to local-studio.
  • Preserved the current root check chain without the removed check:cli script.
  • Kept this PR limited to version alignment; macOS asset publishing remains in ci(release): publish macOS desktop assets #150.

Validation

  • npm run test:release-version (2 tests)
  • Release configuration assertion for the @semantic-release/exec prepare command
  • git diff --check origin/main...HEAD
  • Mandatory pre-push npm --prefix frontend run check:quality gate passed after the rebase

AI Disclosure

AI assistance was used to inspect the release/versioning setup, implement and test the helper, rebase the branch, and perform the follow-up review. I reviewed the resulting diff and command output before updating this PR.

@0xSero

0xSero commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Reviewed — the approach is right: exec prepareCmd in the prepare lifecycle, workspace-only version application, no commits to protected main, and the helper + tests look solid. This genuinely fixes the 0.2.x-vs-v1.x mismatch (#148) since electron-builder reads frontend/package.json.

It's now conflicting because main deleted CONTRIBUTING.md (docs consolidated into AGENTS.md/README.md) and the root check script changed (check:cli removed, package renamed to local-studio). Both are trivial to resolve on rebase — please move the release-process paragraph into AGENTS.md, and update the vllm-studio test fixtures to local-studio while you're there.

Happy to merge once rebased.

@fettpl fettpl force-pushed the fix/release-version-alignment-148 branch from 5bc3523 to 402a570 Compare July 13, 2026 09:18
@fettpl

fettpl commented Jul 13, 2026

Copy link
Copy Markdown
Author

@0xSero requested rebase follow-up is complete in 402a5705.

  • Rebasing onto current main preserved the CONTRIBUTING.md deletion.
  • The release-version guidance now lives in AGENTS.md.
  • Root fixtures use local-studio.
  • The root check chain no longer reintroduces the removed check:cli command.
  • npm run test:release-version passes, and the mandatory pre-push frontend quality gate passed.

GitHub reports #149 mergeable and ready for your review. #150 is stacked on this rebased commit and should be merged after #149.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants