You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Applies semantic-release's computed nextRelease.version to root and frontend package metadata in the release workspace.
Adds a tested scripts/apply-release-version.mjs helper so Electron Builder sees the GitHub release version.
Documents semantic-release as the stable desktop release version source of truth in AGENTS.md.
Context
Addresses #148 and supports the Homebrew-readiness umbrella in #140.
The release bot does not commit package-version bumps to protected main. Package metadata is updated only in the GitHub Actions workspace before later desktop packaging steps.
Review Follow-up
Rebased onto current main after the Local Studio rename.
Preserved the deletion of CONTRIBUTING.md and moved the release-process paragraph into AGENTS.md.
Updated root test fixtures from vllm-studio to local-studio.
Preserved the current root check chain without the removed check:cli script.
Release configuration assertion for the @semantic-release/exec prepare command
git diff --check origin/main...HEAD
Mandatory pre-push npm --prefix frontend run check:quality gate passed after the rebase
AI Disclosure
AI assistance was used to inspect the release/versioning setup, implement and test the helper, rebase the branch, and perform the follow-up review. I reviewed the resulting diff and command output before updating this PR.
Reviewed — the approach is right: execprepareCmd in the prepare lifecycle, workspace-only version application, no commits to protected main, and the helper + tests look solid. This genuinely fixes the 0.2.x-vs-v1.x mismatch (#148) since electron-builder reads frontend/package.json.
It's now conflicting because main deleted CONTRIBUTING.md (docs consolidated into AGENTS.md/README.md) and the root check script changed (check:cli removed, package renamed to local-studio). Both are trivial to resolve on rebase — please move the release-process paragraph into AGENTS.md, and update the vllm-studio test fixtures to local-studio while you're there.
@0xSero requested rebase follow-up is complete in 402a5705.
Rebasing onto current main preserved the CONTRIBUTING.md deletion.
The release-version guidance now lives in AGENTS.md.
Root fixtures use local-studio.
The root check chain no longer reintroduces the removed check:cli command.
npm run test:release-version passes, and the mandatory pre-push frontend quality gate passed.
GitHub reports #149 mergeable and ready for your review. #150 is stacked on this rebased commit and should be merged after #149.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextRelease.versionto root and frontend package metadata in the release workspace.scripts/apply-release-version.mjshelper so Electron Builder sees the GitHub release version.AGENTS.md.Context
Addresses #148 and supports the Homebrew-readiness umbrella in #140.
The release bot does not commit package-version bumps to protected
main. Package metadata is updated only in the GitHub Actions workspace before later desktop packaging steps.Review Follow-up
mainafter the Local Studio rename.CONTRIBUTING.mdand moved the release-process paragraph intoAGENTS.md.vllm-studiotolocal-studio.checkchain without the removedcheck:cliscript.Validation
npm run test:release-version(2 tests)@semantic-release/execprepare commandgit diff --check origin/main...HEADnpm --prefix frontend run check:qualitygate passed after the rebaseAI Disclosure
AI assistance was used to inspect the release/versioning setup, implement and test the helper, rebase the branch, and perform the follow-up review. I reviewed the resulting diff and command output before updating this PR.