fix(build): normalize path separators in the shared-contracts check#183
Merged
0xSero merged 1 commit intoJul 13, 2026
Merged
Conversation
This was referenced Jul 13, 2026
0xSero
approved these changes
Jul 13, 2026
0xSero
left a comment
0xSero
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed the bug on main — relative() output at validate-shared-contracts.mjs:97 is compared against a forward-slash allowlist, so this can never pass on Windows. Normalizing at the single point rel is computed covers both the allowlist check and the duplicate-declaration report, and is a no-op on POSIX. The failing Dependency Review check is repo config (dependency graph disabled), not this PR.
|
🎉 This PR is included in version 1.65.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-shared-contracts.mjsmatchedrelative()output against a forward-slash allowlist; on Windowsrelative()yields backslash paths, so the check failed on every clean tree andnpm run checkcould never pass there. The relative path is now normalized to/before comparison, which also keeps the duplicate-declaration report consistent across hosts. Fixes #182.Validation
npm run check:contracts # passes on Windows 11; POSIX output has no backslashes to replaceUI changes
None.
Risks / rollout notes
None —
replaceAll("\\", "/")is a no-op on POSIXrelative()output.