fix(controller): parse the CUDA UMD version banner from newer drivers#185
Merged
Merged
Conversation
0xSero
approved these changes
Jul 13, 2026
0xSero
left a comment
Collaborator
There was a problem hiding this comment.
Verified against main: the regex at runtime-info.ts:179 only matches CUDA Version:, so driver 610+ machines without nvcc silently report no CUDA — this widening fixes it while keeping the old banner. The extraction to cuda-version.ts is clean (both sync and async call sites use the import) and the three-case test suite runs under CI's bun test src.
|
🎉 This PR is included in version 1.65.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NVIDIA driver 610+ renamed the
nvidia-smibanner field fromCUDA Version:toCUDA UMD Version:, so CUDA detection silently returned nothing on toolkit-less machines running the new driver series (thenvccfallback masked it elsewhere). The parser moves to a smallcuda-version.tsmodule and accepts both spellings; unit tests cover the old banner, the new banner, and no banner. Fixes #184.Validation
Verified live on driver 610.47 (Windows 11, RTX 4070):
/runtime/inforeports the CUDA version again. Pre-610 banners are unaffected — the old spelling still matches.UI changes
None.
Risks / rollout notes
None — pure parser widening; the extracted module is consumed only by runtime-info today.