Skip to content

[Store] Rework state handling of indexer #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chr-hertel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Store] Rework state handling of indexer #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions examples/indexer/index-file-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
*/

use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
use Symfony\AI\Store\Document\Loader;
use Symfony\AI\Store\Document\Loader\TextFileLoader;
use Symfony\AI\Store\Document\Transformer\TextReplaceTransformer;
use Symfony\AI\Store\Document\Transformer\TextSplitTransformer;
Expand All @@ -23,21 +24,22 @@
$store = new InMemoryStore();
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small');
$indexer = new Indexer(
loader: new TextFileLoader(),
loader: new Loader([TextFileLoader::supportedSource() => new TextFileLoader()]),
Copy link
Member Author

@chr-hertel chr-hertel Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also be

new Loader([TextFile::class => new TextFileLoader()]),

or we shift that part into the Loader implementation

vectorizer: $vectorizer,
store: $store,
source: [
dirname(__DIR__, 2).'/fixtures/movies/gladiator.md',
dirname(__DIR__, 2).'/fixtures/movies/inception.md',
dirname(__DIR__, 2).'/fixtures/movies/jurassic-park.md',
],
transformers: [
new TextReplaceTransformer(search: '## Plot', replace: '## Synopsis'),
new TextSplitTransformer(chunkSize: 500, overlap: 100),
],
);

$indexer->index();
$sources = TextFileLoader::createSource([
dirname(__DIR__, 2).'/fixtures/movies/gladiator.md',
dirname(__DIR__, 2).'/fixtures/movies/inception.md',
dirname(__DIR__, 2).'/fixtures/movies/jurassic-park.md',
]);
Comment on lines +36 to +40
Copy link
Member Author

@chr-hertel chr-hertel Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also be like this:

Suggested change
$sources = TextFileLoader::createSource([
dirname(__DIR__, 2).'/fixtures/movies/gladiator.md',
dirname(__DIR__, 2).'/fixtures/movies/inception.md',
dirname(__DIR__, 2).'/fixtures/movies/jurassic-park.md',
]);
$sources = [
new TextFile(dirname(__DIR__, 2).'/fixtures/movies/gladiator.md'),
new TextFile(dirname(__DIR__, 2).'/fixtures/movies/inception.md'),
new TextFile(dirname(__DIR__, 2).'/fixtures/movies/jurassic-park.md'),
];
  • assumption is that factory will help with bundle config
  • validation could move from factory to constructor


$indexer->index($sources);

$vector = $vectorizer->vectorize('Roman gladiator revenge');
$results = $store->query($vector);
Expand Down
13 changes: 7 additions & 6 deletions examples/indexer/index-inmemory-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
*/

use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\Source\DocumentCollection;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Transformer\TextSplitTransformer;
use Symfony\AI\Store\Document\Vectorizer;
Expand All @@ -25,7 +27,7 @@
$store = new InMemoryStore();
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small');

$documents = [
$sources = new DocumentCollection([
new TextDocument(
Uuid::v4(),
'Artificial Intelligence is transforming the way we work and live. Machine learning algorithms can now process vast amounts of data and make predictions with remarkable accuracy.',
Expand All @@ -36,19 +38,18 @@
'Climate change is one of the most pressing challenges of our time. Renewable energy sources like solar and wind power are becoming increasingly important for a sustainable future.',
new Metadata(['title' => 'Climate Action'])
),
];
]);

$indexer = new Indexer(
loader: new InMemoryLoader($documents),
loader: new Loader([DocumentCollectionLoader::supportedSource() => new DocumentCollectionLoader()]),
vectorizer: $vectorizer,
store: $store,
source: null,
transformers: [
new TextSplitTransformer(chunkSize: 100, overlap: 20),
],
);

$indexer->index();
$indexer->index($sources);

$vector = $vectorizer->vectorize('machine learning artificial intelligence');
$results = $store->query($vector);
Expand Down
14 changes: 8 additions & 6 deletions examples/indexer/index-rss-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
*/

use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
use Symfony\AI\Store\Document\Loader;
use Symfony\AI\Store\Document\Loader\RssFeedLoader;
use Symfony\AI\Store\Document\Transformer\TextSplitTransformer;
use Symfony\AI\Store\Document\Vectorizer;
Expand All @@ -23,19 +24,20 @@
$store = new InMemoryStore();
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small');
$indexer = new Indexer(
loader: new RssFeedLoader(HttpClient::create()),
loader: new Loader([RssFeedLoader::supportedSource() => new RssFeedLoader(HttpClient::create())]),
vectorizer: $vectorizer,
store: $store,
source: [
'https://feeds.feedburner.com/symfony/blog',
'https://www.tagesschau.de/index~rss2.xml',
],
transformers: [
new TextSplitTransformer(chunkSize: 500, overlap: 100),
],
);

$indexer->index();
$sources = RssFeedLoader::createSource([
'https://feeds.feedburner.com/symfony/blog',
'https://www.tagesschau.de/index~rss2.xml',
]);

$indexer->index($sources);

$vector = $vectorizer->vectorize('Week of Symfony');
$results = $store->query($vector);
Expand Down
19 changes: 10 additions & 9 deletions examples/indexer/index-with-filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@

use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
use Symfony\AI\Store\Document\Filter\TextContainsFilter;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\Source\DocumentCollection;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Transformer\TextTrimTransformer;
use Symfony\AI\Store\Document\Vectorizer;
Expand All @@ -27,7 +29,7 @@
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small');

// Sample documents with some unwanted content
$documents = [
$documents = new DocumentCollection([
new TextDocument(
Uuid::v4(),
'Artificial Intelligence is transforming the way we work and live. Machine learning algorithms can now process vast amounts of data and make predictions with remarkable accuracy.',
Expand All @@ -48,7 +50,7 @@
'Climate change is one of the most pressing challenges of our time. Renewable energy sources like solar and wind power are becoming increasingly important for a sustainable future.',
new Metadata(['title' => 'Climate Action', 'category' => 'environment'])
),
];
]);

// Create filters to remove unwanted content
$filters = [
Expand All @@ -57,17 +59,16 @@
];

$indexer = new Indexer(
loader: new InMemoryLoader($documents),
loader: new Loader([DocumentCollectionLoader::supportedSource() => new DocumentCollectionLoader()]),
vectorizer: $vectorizer,
store: $store,
source: null,
filters: $filters,
transformers: [
new TextTrimTransformer(),
],
);

$indexer->index();
$indexer->index($documents);

$vector = $vectorizer->vectorize('technology artificial intelligence');
$results = $store->query($vector);
Expand All @@ -81,7 +82,7 @@
}

echo "=== Results Summary ===\n";
echo sprintf("Original documents: %d\n", count($documents));
echo sprintf("Documents after filtering: %d\n", count($results));
echo sprintf("Filtered out: %d documents\n", count($documents) - count($results));
echo sprintf("Original documents: %d\n", count($documents->getDocuments()));
echo sprintf("Documents after filtering: %d\n", $i + 1);
echo sprintf("Filtered out: %d documents\n", count($documents->getDocuments()) - ($i + 1));
echo "\nThe 'Week of Symfony' newsletter and SPAM advertisement were successfully filtered out!\n";
4 changes: 2 additions & 2 deletions examples/memory/mariadb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\MariaDb\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -57,7 +57,7 @@
// create embeddings for documents as preparation of the chain memory
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, $embeddings = 'text-embedding-3-small');
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

// Execute a chat call that is utilizing the memory
Expand Down
4 changes: 2 additions & 2 deletions examples/ollama/rag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Symfony\AI\Platform\Bridge\Ollama\PlatformFactory;
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand All @@ -43,7 +43,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OLLAMA_HOST_URL'), http_client());
$vectorizer = new Vectorizer($platform, env('OLLAMA_EMBEDDINGS'), logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\Cache\Store as CacheStore;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand All @@ -44,7 +44,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/chromadb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\ChromaDb\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -51,7 +51,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/clickhouse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\ClickHouse\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -51,7 +51,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/cloudflare.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\Cloudflare\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -51,7 +51,7 @@
// create embeddings for documents (keep in mind that upserting vectors is asynchronous)
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/elasticsearch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\Elasticsearch\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -50,7 +50,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/in-memory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand All @@ -43,7 +43,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/manticore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\ManticoreSearch\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -51,7 +51,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/mariadb-gemini.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\MariaDb\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -53,7 +53,7 @@
$platform = PlatformFactory::create(env('GEMINI_API_KEY'), http_client());
$model = 'gemini-embedding-exp-03-07?dimensions=768&task_type=SEMANTIC_SIMILARITY';
$vectorizer = new Vectorizer($platform, $model, logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/mariadb-openai.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use Symfony\AI\Platform\Message\Message;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Store\Bridge\MariaDb\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -52,7 +52,7 @@
// create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

$similaritySearch = new SimilaritySearch($vectorizer, $store);
Expand Down
4 changes: 2 additions & 2 deletions examples/rag/meilisearch-hybrid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Symfony\AI\Fixtures\Movies;
use Symfony\AI\Platform\Bridge\OpenAi\PlatformFactory;
use Symfony\AI\Store\Bridge\Meilisearch\Store;
use Symfony\AI\Store\Document\Loader\InMemoryLoader;
use Symfony\AI\Store\Document\Loader\DocumentCollectionLoader;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\TextDocument;
use Symfony\AI\Store\Document\Vectorizer;
Expand Down Expand Up @@ -50,7 +50,7 @@
// Create embeddings for documents
$platform = PlatformFactory::create(env('OPENAI_API_KEY'), http_client());
$vectorizer = new Vectorizer($platform, 'text-embedding-3-small', logger());
$indexer = new Indexer(new InMemoryLoader($documents), $vectorizer, $store, logger: logger());
$indexer = new Indexer(new DocumentCollectionLoader($documents), $vectorizer, $store, logger: logger());
$indexer->index($documents);

// Create a query embedding
Expand Down
Loading
Loading