[Platform] Streamline RawHttpResult for streaming
#1191
+12
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Bug
OskarStark
changed the title
RawHttpResult for streaming
Contributor
|
Can you please rebase? |
lochmueller
force-pushed
the
feature/streamline-raw-http-result
branch
from
a325bd0 to
9ac792b
Compare
Fix: - Skip SSE comments - Skip SSE errors - Drop manual JSON convert process - Use JSON decode from the ServerSentEvent
lochmueller
force-pushed
the
feature/streamline-raw-http-result
branch
from
9ac792b to
1645be2
Compare
Contributor
Author
done. The workflow errors are not related to my changes... |
Contributor
|
Lets merge #1204 first, rebase and adjust the testcase |
OskarStark
added a commit
that referenced
this pull request
Dec 18, 2025
This PR was merged into the main branch. Discussion ---------- [Platform] Add test for `RawHttpResult` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | -- | License | MIT Should be merged before #1191 Commits ------- ff0ec93 [Platform] Add test for RawHttpResult
Contributor
|
I merged my PR, can you please update the test? thanks |
chr-hertel
reviewed
Dec 20, 2025
Comment on lines
-50
to
-59
| // Split in case of multiple JSON objects | ||
| $deltas = explode(",\r\n", $jsonDelta); | ||
|
|
||
| foreach ($deltas as $delta) { | ||
| if ('' === trim($delta)) { | ||
| continue; | ||
| } | ||
|
|
||
| yield json_decode($delta, true, flags: \JSON_THROW_ON_ERROR); | ||
| } |
Member
There was a problem hiding this comment.
what's the reason for removing this?
there is no replacement for this part or do i miss something?
Member
There was a problem hiding this comment.
background for having this was gemini api streaming parts of a larger json document - which cannot be decoded right away - testing with examples/gemini/stream.php might help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
: OPENROUTER PROCESSINGhttps://openrouter.ai/docs/api/reference/streaming#additional-information