Conversation
Fluzko
marked this pull request as ready for review
August 31, 2026 19:03
jackh726
reviewed
Sep 5, 2026
jackh726
left a comment
Contributor
There was a problem hiding this comment.
Not sure we need this (I think of RFDs about design - and this is just about updating our support).
I can merge if you think we should; otherwise, let's just merge the impl PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an RFD proposing we drop the
geminiagent and support Antigravity CLI (agy) instead.Gemini CLI's consumer sign-in is closed — "Sign in with Google" now fails with a message from Google telling you to migrate to Antigravity. That's the path our users take, so supporting Gemini means supporting an agent most people can't log into.
Antigravity is not a rename. Skills and MCP map over cleanly (it reads the same
.agents/skills/layout we already write, and the familiarmcpServersshape), but hooks are a new file, new shape, new event names, new payload fields and a new output contract. That's why this replaces the agent rather than adding one.Two findings from testing
agy1.1.22 that shaped the design:PreToolUsehook returning{}denies the tool call. Our dispatcher returns{}whenever no plugin contributed, which is the common case — so a naive port would block every tool call. Exit codes are ignored entirely.SessionStartevent. The RFD derives one fromPreInvocationplus the first sighting of aconversationId, sinceinvocationNumresets every turn.The RFD includes a proposed agent-details reference page and a six-step implementation plan. No code changes here.
Disclosure questions
AI disclosure.
Claude did the research and drafted the RFD, including running an instrumented
agylocally to verify the hook contract rather than relying on docs. Direction, scope and the design calls were mine.Questions for reviewers.
conversationIds) is the least conventional part of the design — worth a look.