Bump NATS.Jwt, add net10, switch to orbit test server#19
Conversation
- NATS.Jwt 1.0.0-preview.16 -> 1.0.0 - Add net10.0 to library, examples, tests, compat targets - Migrate callout.net.sln to .slnx - Replace local NatsServerProcess with Synadia.Orbit.Testing.NatsServerProcessManager 1.0.0-preview.4 - Pass withJs=false for Connect_with_jwt since orbit's default JetStream flag breaks operator-mode server startup
|
Claude finished @mtmk's task in 1m 52s —— View job PR Review
SummaryClean housekeeping PR. The NATS.Jwt bump to stable, One real issue found:
One observation: The test project targets Minor note:
|
- Directory.Build.props: restore net9.0 in IsTrimmable/isAotCompatible condition - test.yml: update X_COMPAT_EXE to bin/Debug/net10.0/compat to match compat TFM bump
This comment was marked as resolved.
This comment was marked as resolved.
- Tests.csproj: add net9.0 so the TFM the library ships is actually exercised - test.yml: add 10.x to setup-dotnet since we build net10.0 binaries
|
Claude finished @mtmk's task in 2m 44s —— View job PR Review
SummaryThis PR is in good shape. The three issues flagged in earlier review passes have all been resolved in subsequent commits:
Changes reviewed
Minor observations
No blocking issues. The PR looks ready to merge. |
Bumps NATS.Jwt to 1.0.0, adds net10.0 to all projects, migrates the solution file to .slnx, and swaps the locally-vendored NatsServerProcess for the Synadia.Orbit.Testing.NatsServerProcessManager package.
Connect_with_jwt passes withJs=false because orbit's default JetStream flag (-js -sd ...) prevents the operator-mode server from writing its ports file within the startup retry window.