Skip to content

Bump nats-server test matrix to v2.11/v2.12#64

Merged
mtmk merged 1 commit into
mainfrom
ci-bump-nats-server-matrix
May 8, 2026
Merged

Bump nats-server test matrix to v2.11/v2.12#64
mtmk merged 1 commit into
mainfrom
ci-bump-nats-server-matrix

Conversation

@mtmk
Copy link
Copy Markdown
Collaborator

@mtmk mtmk commented May 8, 2026

Drop v2.10 and add v2.12 from the test matrix. v2.14 is the latest server release, so v2.10 is two majors behind; v2.12 covers the version that introduces atomic batch publish used by JetStream.Publisher.

@synadia-claude-reviewer
Copy link
Copy Markdown

synadia-claude-reviewer Bot commented May 8, 2026

Claude finished @mtmk's task in 38s —— View job


PR Review: Bump nats-server test matrix to v2.11/v2.12

  • Gather context
  • Read CLAUDE.md for repo-specific instructions
  • Examine the PR diff
  • Analyze the change
  • Post review feedback

Review

The change is correct and well-motivated. Dropping v2.10 is reasonable — it's two minor versions behind the latest (v2.14), and adding v2.12 is specifically justified by the atomic batch publish support that JetStream.Publisher relies on (introduced in that server version, and the subject of the recent batch publisher work in this repo).

The resulting matrix (v2.11, v2.12, latest, main) maintains good coverage:

  • v2.11 — recent stable floor
  • v2.12 — minimum required for atomic batch publish / JetStream.Publisher correctness
  • latest — current stable release
  • main — upcoming/bleeding-edge server

No correctness, security, or performance concerns. LGTM.

@mtmk mtmk merged commit e56e1cf into main May 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant