Skip to content

Release jetstream-extra v0.3.0#25

Merged
Jarema merged 1 commit into
mainfrom
release-03
May 11, 2026
Merged

Release jetstream-extra v0.3.0#25
Jarema merged 1 commit into
mainfrom
release-03

Conversation

@Jarema
Copy link
Copy Markdown
Collaborator

@Jarema Jarema commented May 11, 2026

Signed-off-by: Tomasz Pietrek tomasz@synadia.com

@synadia-claude-reviewer
Copy link
Copy Markdown

synadia-claude-reviewer Bot commented May 11, 2026

Claude finished @Jarema's task in 1m 0s —— View job


PR Review

  • Gather context (PR diff, CLAUDE.md, workspace Cargo files)
  • Review version bump for correctness and consistency
  • Post review summary

Summary

The change itself (bumping jetstream-extra from 0.2.10.3.0) is straightforward and correct. One issue to flag:

nats-counters/Cargo.toml still pins jetstream-extra = "0.2.1"

nats-counters declares:

jetstream-extra = { version = "0.2.1", path = "../jetstream-extra" }

In workspace builds the path takes precedence, so this compiles fine locally. But Cargo's ^0.2.1 constraint (>=0.2.1, <0.3.0) will be what ends up in the published crate on crates.io — meaning a published nats-counters would never resolve to jetstream-extra 0.3.0. If nats-counters is intended to depend on features added in 0.3.0, this needs to be bumped too.

If nats-counters is not being published alongside this release and its API doesn't rely on anything new in 0.3.0, this can be deferred — but it's worth a conscious check before the next nats-counters release.

Signed-off-by: Tomasz Pietrek <tomasz@synadia.com>
@Jarema Jarema requested a review from caspervonb May 11, 2026 14:43
Copy link
Copy Markdown
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit b7c6ee7 into main May 11, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants