fix(deps): resolve critical audit finding and high-severity build/test findings#115
Merged
Conversation
jspdf <=4.2.0 has a critical advisory bundle (PDF object injection via addJS, AcroForm arbitrary JS execution, FreeText object injection, DoS via malicious GIF dimensions, HTML injection). 4.2.1 fixes them. Patch-level bump within the same major; the only usage (components/print/pdf.js) relies on stable rendering API (addImage/text/rect/output) unaffected by the fixes.
npm audit fix --force across build- and test-only dependencies (electron-builder, webpack, babel, glob/minimatch/picomatch, eslint chains), bringing high findings from 13 down to 1. mocha bumped to ^11.7.5 (latest); since even the latest mocha still bundles vulnerable serialize-javascript (<=7.0.4) and diff (<=8.0.2) with no upstream fix, both are pinned via overrides to ^7.0.5 / ^9.0.0. Full test suite (332) passes with the forced transitive versions. The remaining high finding, electron (<=39.8.4), is a runtime dependency whose fix is a major bump; it is handled separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the critical npm audit finding and all high-severity findings in build/test tooling. Brings
npm auditfrom critical 1 / high 13 down to critical 0 / high 1.Changes
Fixes
addJS, AcroForm arbitrary JS execution, FreeText object injection, DoS via malicious GIF dimensions, HTML injection). Patch-level bump; the only usage (components/print/pdf.js) relies on stable rendering API unaffected by the fixes.npm audit fix --forceacross electron-builder, webpack, babel, eslint and glob/minimatch/picomatch chains; clears 12 high findings that never ship to users.serialize-javascript(≤7.0.4) anddiff(≤8.0.2) with no upstream fix, both are pinned viaoverridesto^7.0.5/^9.0.0.Validation
npm audit: critical 0, high 1, moderate 0, low 0 (was 1 / 13 / 10 / 2)serialize-javascript@7/diff@9npm run lint: cleanOut of scope
The remaining high finding is electron (
<=39.8.4, 17 advisories). It is a runtime dependency whose fix requires a major bump (≥39 / 42.2.0) and real application testing — handled in a separate branch/PR.