Skip to content

feat: settings design updates v60#490

Open
pwltr wants to merge 10 commits intomasterfrom
feat/settings-v60
Open

feat: settings design updates v60#490
pwltr wants to merge 10 commits intomasterfrom
feat/settings-v60

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented Mar 13, 2026

Description

From design prototype changelog v60:

  • Added tab navigation, renamed, reordered, and regrouped multiple settings and options for clarity
  • Added icons to all major settings for faster at-a-glance scanning
  • Expanded the amount of displayed selected values (gray, displayed right side of row) for faster at-a-glance scanning
  • Reworked the UX and logic for enabling, disabling, and changing the PIN
  • Removed Support from Settings and moved it to the main menu
  • Redesigned the Support screen layout and visual style

Closes #496

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.17.-.2026-03-26.at.17.53.02.mov

QA Notes

Mostly a redesign. Testing is needed mostly in the updated PIN setup flow.

@pwltr pwltr force-pushed the feat/settings-v60 branch from 40c4c3d to 196106c Compare March 13, 2026 09:19
@pwltr pwltr self-assigned this Mar 13, 2026
@pwltr pwltr force-pushed the feat/settings-v60 branch from 196106c to ac406bf Compare March 16, 2026 15:47
@pwltr pwltr added this to the 2.2.0 milestone Mar 16, 2026
@pwltr pwltr force-pushed the feat/settings-v60 branch 2 times, most recently from 922a3fa to dc6aa77 Compare March 24, 2026 13:36
@pwltr pwltr linked an issue Mar 25, 2026 that may be closed by this pull request
@pwltr pwltr force-pushed the feat/settings-v60 branch 2 times, most recently from bd45417 to 74aa869 Compare March 26, 2026 16:51
@pwltr pwltr marked this pull request as ready for review March 26, 2026 16:55
@claude

This comment has been minimized.

@pwltr pwltr force-pushed the feat/settings-v60 branch from 74aa869 to 5177dbe Compare March 27, 2026 09:45
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Found 3 issues. See inline comments below.

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Some inconsistencies between Android implementation:

  • Back up wallet guarded by PIN in Android - not in iOS. When PIN is enabled the "Back up your wallet" setting requires PIN. Also in "Reset wallet -> Back Up First"; see: feat: settings design updates v60 bitkit-android#857 (comment)

  • when changing PIN, there is "Forgot your PIN?" which is clickable in Android and triggers "Reset flow". On iOS - not clickable

Screen.Recording.2026-03-27.at.14.57.52.mov

This is actually the same as on Android (may be good opportunity to fix, or address separately):

  • "Forgot your PIN?" is clickable on launching the wallet, but the flow informs "Reset (Requires Recovery Phrase)" but in fact the wallet is just resetted.
Screen.Recording.2026-03-27.at.15.01.10.mov

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Mar 27, 2026

This flow is not specified to be gated by auth. If you think this makes sense please leave a comment in Figma. Also need to clarify what happens to the timed backup sheet prompt and the suggestion card if a PIN is set (whether to show it at all, where to ask for PIN) etc. Better to do this separately than on the fly in this PR.

  • when changing PIN, there is "Forgot your PIN?" which is clickable in Android and triggers "Reset flow". On iOS - not clickable

Fixed in ce8d413

  • "Forgot your PIN?" is clickable on launching the wallet, but the flow informs "Reset (Requires Recovery Phrase)" but in fact the wallet is just resetted.

This is expected, the wallet is wiped so the user needs to make sure they have their recovery phrase before continuing.

@piotr-iohk
Copy link
Copy Markdown
Collaborator

"Forgot your PIN?" is clickable on launching the wallet, but the flow informs "Reset (Requires Recovery Phrase)" but in fact the wallet is just resetted.
This is expected, the wallet is wiped so the user needs to make sure they have their recovery phrase before continuing.

Got it. Having read Reset (Requires Recovery Phrase) I was somehow expecting to be asked about recovery phrase on resetting step, but I guess makes sense now 🤷‍♂️

@jvsena42
Copy link
Copy Markdown
Member

Testing...

Copy link
Copy Markdown
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found that two small issues

Tested:

  • Could switch tabs by horizontal swipe, like in Activities screen and Qr code sheet ❌
  • General
    • With language -> display selected language
    • Local Currency -> Display selected currency and symbol
    • Widgets -> Display on/off
    • Transaction speed -> Display the speed in text and icon
    • Quickly -> on/off
    • Background Payments -> on/off
  • Security
    • Backup navigation
    • Reset navigation
    • PIN code -> enabled / change pin / disable
  • Advanced
    • Address type -> Display selected address
    • Coin selection -> Display Autopilot/manual
    • Lightning connections -> Display channel count
    • Lightning node -> Display first 5 char of node id
    • Electrum server -> Display "Auto" for default and first chars for custom ❌

@pwltr pwltr requested review from jvsena42 and piotr-iohk March 31, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: App not wiped when exceeding maximum PIN attempts

3 participants