Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR introduces incognito mode, adding support across icons, accessibility, chat persistence, and UI components with conditional behavior based on the incognito flag.
- Assets: New incognito icons in
/macos/Onit/Assets.xcassets/Icons/incog-off.imageset/Contents.jsonand/macos/Onit/Assets.xcassets/Icons/incog-on.imageset/Contents.jsonlack filenames for 2x/3x scales; verify if intentional. - Accessibility:
AccessibilityNotificationsManager.swiftnow bypasses context and text processing when incognito is enabled. - Chat & Input:
Model+Chat.swiftandModel+Input.swiftprevent saving auto-context and history; ensure PostHog “incognito_mode_enabled” event is logged. - UI Updates:
ChatView.swift,IncognitoDismissable.swift,HistoryRowView.swift,ContextPickerView.swift, andPaperclipButton.swiftcorrectly adapt to incognito mode. - Shortcuts & Toolbar:
KeyboardShortcutsManager.swiftandToolbar.swiftinclude incognito conditions and toggle logic to clear context and start a new chat.
13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
247
to
260
|
|
||
| var incognitoMode: some View { | ||
| Button { | ||
| incognitoModeEnabled.toggle() | ||
| if incognitoModeEnabled { model.clearAutoContext() } | ||
| model.newChat() | ||
| } label: { | ||
| Image(incognitoModeEnabled ? .incogOn : .incogOff) | ||
| .renderingMode(.template) | ||
| .padding(4) | ||
| .foregroundColor(incognitoModeEnabled ? .blue400 : .gray200) | ||
| } | ||
| .tooltip(prompt: "Incognito mode (auto-context off)") | ||
| } |
Contributor
There was a problem hiding this comment.
logic: Check if calling model.newChat() on every toggle is the intended behavior. Ensure that resetting the conversation upon enabling or disabling incognito mode meets the UX requirements.
timlenardo
approved these changes
Apr 17, 2025
Contributor
timlenardo
left a comment
timlenardo
left a comment
There was a problem hiding this comment.
LGTM- one small copy update but otherwise great!
| .padding(4) | ||
| .foregroundColor(incognitoModeEnabled ? .blue400 : .gray200) | ||
| } | ||
| .tooltip(prompt: "Incognito mode (auto-context off)") |
Contributor
There was a problem hiding this comment.
This shouldn't say "auto-context off" since incognito just means it doesn't get added to history
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Notes
incognito_mode_enabledevent for PostHog.