Text Highlight (Pin - 2): Update to Managers and UI#343
Closed
lk340 wants to merge 3 commits intofeature/text-highlight/history-and-messages-builderfrom
Closed
Conversation
… with pinned text highlight updates. * `AccessibliityNotificationsManager` now properly handles removing `InputView` from the UI when it matches the current highlighted text, and the current highlighted text is about to be removed. * `AccessibliityNotificationsManager` also now handles setting the unpinned highlighted context and showing it in the UI. * `KeyboardShortcutsManager` now clears all states related to highlighted text.
* Add pin icon. * ContextTag can now handle the pin action and shows pinned corner icon when pinned. * ExternalTetheredButton now accounts for both auto-highlighted and tracked highlighted text. * InputView `smallRemove` button now clears the unpinned highlighted text context tag when it matches the removed InputView text. * Update FinalContextView to now show full array of input (highlighted text) contexts. * Update PromptCore to properly show the selected highlighted text context.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR implements significant changes to support a new pinned text highlight feature, focusing on the underlying management systems and UI updates. The key changes include:
- Input state management has been refactored from a single
pendingInputto multiple states (selectedPendingInput,unpinnedPendingInput,trackedPendingInput,pinnedPendingInputs) - AccessibilityNotificationsManager and KeyboardShortcutsManager have been updated to handle these new input states
- UI components (ContextTag, InputButtons, etc.) have been modified to support pinning functionality
- Core data structures like Input have been made Hashable to support new collection requirements
The changes lay the groundwork for users to pin multiple text selections while maintaining a clear separation between pinned and unpinned text states.
Confidence score: 3/5
- While the code changes are well-structured, this PR intentionally does not build as it's part of a larger feature implementation
- The score reflects the incomplete nature of the changes and potential edge cases in state management that need attention
- Files needing careful review:
- AccessibilityNotificationsManager.swift: Complex state management logic
- OnitPanelState.swift: Core state changes
- InputButtons.swift: Potential edge cases in state clearing logic
11 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR only tackles the
AccessibilityNotificationsManager,KeyboardShortcutsManagerand minor UI aspects of the pinned text highlight feature (FileRowis the "key" UI aspect of this feature, so it was turned into its own PR). As a result, this branch will not build. I did this to separate concerns and make the updated code more reviewable.I've separated the manager updates and UI updates by commit, so I recommend reviewing this PR on a commit-by-commit basis.
If you want to test the full buildable version of the pinned text highlight feature, checkout to the branch in the last PR: #341
Parts
YOU ARE HERE(Pin 2)