Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions macos/Onit/PanelStateManager/PanelStateBaseManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ class PanelStateBaseManager: PanelStateManagerLogic {
}
closePanels()
hideTetherWindow()
for state in states {
state.unsubscribeAsHighlightedTextDelegate()
}

state = defaultState
tetherButtonPanelState = nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ class PanelStatePinnedManager: PanelStateBaseManager, ObservableObject {

self.state = state
states = [state]
state.subscribeAsHighlightedTextDelegate()

globalMouseMonitor = NSEvent.addGlobalMonitorForEvents(matching: .mouseMoved) { [weak self] event in
guard let self = self else { return }
Expand Down Expand Up @@ -114,7 +115,7 @@ class PanelStatePinnedManager: PanelStateBaseManager, ObservableObject {
dragManager.stopMonitoring()
dragManagerCancellable?.cancel()
draggingWindow = nil

state.unsubscribeAsHighlightedTextDelegate()
state.removeDelegate(self)

hintYRelativePosition = nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ class PanelStateTetheredManager: PanelStateBaseManager, ObservableObject {
dragManager.stopMonitoring()
dragManagerCancellable?.cancel()
draggingState = nil

for (_, state) in statesByWindow {
state.unsubscribeAsHighlightedTextDelegate()
}
super.stop()

statesByWindow = [:]
Expand Down Expand Up @@ -240,7 +242,7 @@ class PanelStateTetheredManager: PanelStateBaseManager, ObservableObject {
panelState = activeState
} else {
panelState = OnitPanelState(trackedWindow: trackedWindow)

panelState.subscribeAsHighlightedTextDelegate()
statesByWindow[trackedWindow] = panelState
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
//
// HighlightedTextDelegate.swift
// Onit
//
// Created by TimL on 07/29/2025.
//

import Foundation

@MainActor
protocol HighlightedTextDelegate: AnyObject {
/// Called when highlighted text has changed
/// - Parameters:
/// - selectedText: The newly selected text, or nil if text was deselected
/// - application: The name of the application where the text was selected
func highlightedTextManager(_ manager: HighlightedTextManager, didChange selectedText: String?, application: String?)
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ class HighlightedTextManager: ObservableObject {
// Published property for selected text that QuickEditManager can observe
@Published var selectedText: String?

// MARK: - Delegates

private var delegates = NSHashTable<AnyObject>.weakObjects()

// MARK: - Private initializer

private init() {
Expand All @@ -39,6 +43,22 @@ class HighlightedTextManager: ObservableObject {

// MARK: - Functions

// MARK: - Delegate Management

func addDelegate(_ delegate: HighlightedTextDelegate) {
delegates.add(delegate)
}

func removeDelegate(_ delegate: HighlightedTextDelegate) {
delegates.remove(delegate)
}

private func notifyDelegates(_ notification: (HighlightedTextDelegate) -> Void) {
for case let delegate as HighlightedTextDelegate in delegates.allObjects {
notification(delegate)
}
}

func setCurrentSource(_ source: String?) {
currentSource = source
}
Expand Down Expand Up @@ -97,21 +117,22 @@ class HighlightedTextManager: ObservableObject {
let selectedText = text,
HighlightedTextValidator.isValid(text: selectedText) else {

PanelStateCoordinator.shared.state.pendingInput = nil
PanelStateCoordinator.shared.state.trackedPendingInput = nil
// Update the published selectedText property
self.selectedText = nil

// Notify delegates that text was deselected
notifyDelegates {
$0.highlightedTextManager(self, didChange: nil, application: currentSource)
}
return
}

// Update the published selectedText property
self.selectedText = selectedText

let input = Input(selectedText: selectedText, application: currentSource ?? "")

if Defaults[.autoAddHighlightedTextToContext] {
PanelStateCoordinator.shared.state.pendingInput = input
} else {
PanelStateCoordinator.shared.state.trackedPendingInput = input
// Notify delegates about the text change
notifyDelegates {
$0.highlightedTextManager(self, didChange: selectedText, application: currentSource)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//

import AppKit
import Defaults

extension OnitPanelState: NSWindowDelegate {

Expand All @@ -29,3 +30,22 @@ extension OnitPanelState: NSWindowDelegate {
}
}
}

extension OnitPanelState: HighlightedTextDelegate {

func highlightedTextManager(_ manager: HighlightedTextManager, didChange selectedText: String?, application: String?) {
if let selectedText = selectedText {
let input = Input(selectedText: selectedText, application: application ?? "")

if Defaults[.autoAddHighlightedTextToContext] {
pendingInput = input
} else {
trackedPendingInput = input
}
} else {
// Text was deselected
pendingInput = nil
trackedPendingInput = nil
}
}
}
11 changes: 11 additions & 0 deletions macos/Onit/UI/Panels/State/OnitPanelState.swift
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,17 @@ class OnitPanelState: NSObject {
currentAnimationTask = nil
}

// MARK: - Setup

public func subscribeAsHighlightedTextDelegate() {
HighlightedTextManager.shared.addDelegate(self)
}

public func unsubscribeAsHighlightedTextDelegate() {
HighlightedTextManager.shared.removeDelegate(self)
}


// MARK: - Delegates

func addDelegate(_ delegate: OnitPanelStateDelegate) {
Expand Down
2 changes: 1 addition & 1 deletion macos/Onit/UI/QuickEdit/QuickEditManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ extension QuickEditManager {
}

func caretDidDisappear() {
if !hasTextSelection(PanelStateCoordinator.shared.state.pendingInput?.selectedText ?? PanelStateCoordinator.shared.state.trackedPendingInput?.selectedText) {
if !hasTextSelection(highlightedTextManager.selectedText) {
hideHint()
}
}
Expand Down